docs(rules): point agent runbooks at the real workspace layout - #1871
Conversation
Conformance scan: eight rules/persona files still referenced a gateway/ crate directory, gateway/policies.cedar, gateway/src/policy.rs and helm/aegisagent — none exist. Commands now use the workspace-level cargo invocations from CLAUDE.md, the root policies.cedar, the policy engine's real home (lib/policy/src/cedar.rs), src/src/ for bind-audit greps, and helm/aegis-gateway; frontmatter globs updated to match.
|
Warning Review limit reached
Next review available in: 5 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (11)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates various Claude rule configuration files to reflect a repository restructuring, shifting paths from the old gateway/ directory to the new src/ and lib/ directories, and updating Cargo commands to run at the workspace level. The review feedback points out several redundant or duplicate glob patterns introduced in the rule files (such as developer.md, database_migration.md, sqlite_usage.md, axum_patterns.md, security_scan.md, and auditor.md) where broader wildcard patterns already encompass the more specific paths.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| - "src/**/*" | ||
| - "src/**/*" |
There was a problem hiding this comment.
There is a duplicate glob entry for "src/**/*" on lines 3 and 4. This can be simplified by removing the duplicate.
| - "src/**/*" | |
| - "src/**/*" | |
| - "src/**/*" |
| - "lib/storage/**/*" | ||
| - "lib/storage/**/*.rs" | ||
| - "gateway/migrations/**/*" | ||
| - "lib/storage/migrations/**/*" |
There was a problem hiding this comment.
The glob "lib/storage/**/*" recursively matches all files and directories under lib/storage/. Therefore, the more specific globs "lib/storage/**/*.rs" and "lib/storage/migrations/**/*" are redundant and can be removed.
| - "lib/storage/**/*" | |
| - "lib/storage/**/*.rs" | |
| - "gateway/migrations/**/*" | |
| - "lib/storage/migrations/**/*" | |
| - "lib/storage/**/*" |
| - "lib/storage/**/*" | ||
| - "lib/storage/**/*.rs" | ||
| - "gateway/migrations/**/*" | ||
| - "lib/storage/migrations/**/*" |
There was a problem hiding this comment.
The glob "lib/storage/**/*" recursively matches all files and directories under lib/storage/. Therefore, the more specific globs "lib/storage/**/*.rs" and "lib/storage/migrations/**/*" are redundant and can be removed.
| - "lib/storage/**/*" | |
| - "lib/storage/**/*.rs" | |
| - "gateway/migrations/**/*" | |
| - "lib/storage/migrations/**/*" | |
| - "lib/storage/**/*" |
| - "src/src/**/*.rs" | ||
| - "src/**/*.rs" |
There was a problem hiding this comment.
The glob "src/**/*.rs" recursively matches all .rs files under src/, which includes all files matched by "src/src/**/*.rs". Therefore, "src/src/**/*.rs" is redundant and can be removed.
| - "src/src/**/*.rs" | |
| - "src/**/*.rs" | |
| - "src/**/*.rs" |
| - "src/src/**/*.rs" | ||
| - "src/**/*.rs" |
There was a problem hiding this comment.
The glob "src/**/*.rs" recursively matches all .rs files under src/, which includes all files matched by "src/src/**/*.rs". Therefore, "src/src/**/*.rs" is redundant and can be removed.
| - "src/src/**/*.rs" | |
| - "src/**/*.rs" | |
| - "src/**/*.rs" |
| - "lib/policy/src/cedar.rs" | ||
| - "policies.cedar" | ||
| - "SECURITY.md" | ||
| - "lib/policy/**/*" |
There was a problem hiding this comment.
The glob "lib/policy/**/*" recursively matches all files under lib/policy/, which includes "lib/policy/src/cedar.rs". Therefore, "lib/policy/src/cedar.rs" is redundant and can be removed.
| - "lib/policy/src/cedar.rs" | |
| - "policies.cedar" | |
| - "SECURITY.md" | |
| - "lib/policy/**/*" | |
| - "policies.cedar" | |
| - "SECURITY.md" | |
| - "lib/policy/**/*" |
Summary
Architecture-conformance scan follow-up to #1870 (this commit was pushed to that branch minutes after its squash-merge, so it re-lands here — same race as #1861/#1869).
Eleven
.claude/rules/runbook/persona files still directed agents at a workspace layout that does not exist: agateway/crate directory (gateway/Cargo.toml,gateway/src/policy.rs,gateway/src/config.rs,gateway/policies.cedar,gateway/migrations/), andhelm/aegisagent. Every command an agent copy-pasted from them failed.Now aligned with reality:
CLAUDE.md(--workspace -- --test-threads=1,fmt --all,clippy --workspace --all-targets,-p gatewayfor run/release builds)policies.cedar; policy engine tests atlib/policy/src/cedar.rssrc/; startup inspection points atsrc/src/main.rshelm/aegis-gatewaysrc/src/**/*.rs,lib/storage/**/*,lib/storage/migrations/**/*); duplicate glob dedupedTest plan
node scripts/validate-docs.mjs— 0 errors/warningsgrep -rn "gateway/" .claude/rules/— no stale references remain (onlyhelm/aegis-gateway,-p gateway,llm-gateway,mcp-gatewaylegitimates)