fix(event): skip rotating native stress under loom feature - #1874
fix(event): skip rotating native stress under loom feature#1874lavkushry wants to merge 1 commit into
Conversation
RotatingAdmissionChannel uses Loom atomics when --features loom is on; std::thread stress in tests/rotating.rs must not run outside loom::model. Gate the integration file with cfg(not(feature = "loom")), matching admission/published_slab/spsc, so all-features CI stays green while native and sanitizer lanes still exercise the stress suite.
|
Warning Review limit reached
Next review available in: 53 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request disables the rotating.rs integration tests when the loom feature is enabled by adding the `#
|
Superseded by #1875 (includes this Loom |
|
Superseded by #1875 (Loom gate + in-place pool rebind). |
Summary
Fixes CI job Event primitives native + Loom after ADR-0010 rotating stress landed.
cargo test -p aegis-event --all-features(and loom-enabled builds) compileRotatingAdmissionChannelwith Loom atomics.lib/event/tests/rotating.rsuse nativestd::threadoutsideloom::model, which panics: cannot access Loom execution state from outside a Loom model.#![cfg(not(feature = "loom"))]— same pattern asadmission.rs,published_slab.rs,spsc.rs.loom_rotating_boundary_is_lossless_and_in_orderremains the Loom model; native/sanitizer lanes still run the cross-thread stress tests.Test plan
cargo test -p aegis-event --test rotating(2 pass)cargo test -p aegis-event --all-features(exit 0; rotating harness runs 0 tests under loom)cargo test -p aegis-event --features loom loom_(exit 0)Related