Skip to content

Recheck feature profiles that were assumed after a timeout - #2193

Draft
lackas wants to merge 1 commit into
lbbrhzn:mainfrom
lackas:recheck-assumed-features
Draft

lackas wants to merge 1 commit into
lbbrhzn:mainfrom
lackas:recheck-assumed-features

Conversation

@lackas

@lackas lackas commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Since #2164 a charger that does not answer GetConfiguration(SupportedFeatureProfiles) during setup is set to Core, and because setup then counts as successful, a later BootNotification no longer queries the profiles again. Before #2164 the failed setup was retried on the next BootNotification and picked up the real profiles.

This keeps the Core fallback but remembers that the profiles are only assumed, and asks again on the next BootNotification and every five minutes until the charger answers. Only the first timeout warns and notifies.

Possibly related to #2089.

@lackas
lackas deployed to continuous-integration October 7, 2026 13:00 — with GitHub Actions Active
@coderabbitai

coderabbitai Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov

codecov Bot commented Oct 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 97.35%. Comparing base (487fc8f) to head (6c0b0fe).

Files with missing lines Patch % Lines
custom_components/ocpp/chargepoint.py 95.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2193      +/-   ##
==========================================
- Coverage   97.36%   97.35%   -0.01%     
==========================================
  Files          12       12              
  Lines        4362     4387      +25     
==========================================
+ Hits         4247     4271      +24     
- Misses        115      116       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This branch was successfully deployed

1 active deployment
continuous-integration — 6c0b0fe4 Deployed Oct 7, 2026 by lackas via Run tests #3740
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant