Python 3.9 type hints - #2
Open
El-Naizin wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I came across this repository, which was very useful to me, so thank you for the code 😄
I noticed there were no python 3.9 type hints, which help me code, especially for the unreal types. (vscode does not understand the comment style type hints).
I removed the inheritance from (object) in classes, which were used in python 2 but are not needed in python 3.
I applied the black formatter, but I can remove that if you prefer to only have the type hints and nothing else.
Other considerations that could be useful, but would need a bit of code change so I didn't include it yet (I can if you want it):
RenderRequestclass, you could use a dataclass