fix(memory): only a goal the person typed is theirs for remember to quote

agentFlow handed every goal to the agent as goalText, the words `remember` and `forget` may quote
as the person's. Not every goal is typed: retryDiagram builds one from the model's own diagram
title and validation messages, and Continue and a resumed goal are not typed now. After a click
on Retry, the model could quote its own generated text and have a note credited to the person.

goalText is now typedGoalText(text, opts): the goal when opts.typed (handleSend), else ''. This is
the rule develop already applies to the Ask When Risky reviewer (rememberTypedGoal, #112). Tests:
the helper on its own, a guard that agentFlow passes it, and the real agent run with a Retry
prompt, where nothing of it reaches the person's words.

Author: ndemianc

extensions/levelcode-ai/extension.js

@@ -2346,6 +2346,12 @@ async function compactAgentMemory() {
 }
 
 let lastAgentGoal = null;   // remembered so the response bar's Retry can re-run it
+/**
+ * The goal as the person typed it, for `remember` and `forget` to quote: '' unless `opts.typed`. A Retry of a
+ * diagram is built from the model's own title and validation messages, and Continue or a resumed goal is not
+ * typed now; none of them is the person's word to remember (the same rule as rememberTypedGoal below).
+ */
+function typedGoalText(text, opts) { return (opts && opts.typed) ? String(text || '') : ''; }
 /**
  * Only what the person typed becomes their word to the Ask When Risky reviewer. A retried or generated goal
  * stays activity: a typed goal that Retry repeats is already on the list, and one from a resumed session
@@ -2467,7 +2473,7 @@ async function agentFlow(text, imageBlocks, opts) {
 			recallSessions: (aiConfig().get('sessions.memory.enabled', true) && aiConfig().get('sessions.memory.recallTool', true)) ? recallSessionsTool : undefined,
 			// Memory the person asks for: the remember/forget tools, and the goal as typed, which is what a
 			// note's quoted words are checked against (docs/levelcode-sessions-memory.md §12).
-			goalText: String(text || ''),
+			goalText: typedGoalText(text, opts),
 			memoryNotes: (aiConfig().get('sessions.memory.enabled', true) && aiConfig().get('sessions.memory.notes', true)) ? { remember: rememberNoteTool, forget: forgetNoteTool } : undefined,
 
 			// MCP (docs/MCP.md S3). Config is read HERE and handed in, like verify/commandTimeout, so

extensions/levelcode-ai/test/memoryNotesHost.test.js

@@ -104,8 +104,8 @@ const host = new Function('env', [
 	"'use strict';",
 	'const { vscode, sessionMemory, dbg, sessionsManager, postMemoryDigest, handleSessionAction } = env;',
 	'const sessionsWebview = env.sessionsWebview;',
-	extract('rememberNoteTool'), extract('forgetNoteTool'), extract('refreshMemoryViews'), extract('searchSessionsQuickPick'),
-	'return { rememberNoteTool, forgetNoteTool, searchSessionsQuickPick };'
+	extract('rememberNoteTool'), extract('forgetNoteTool'), extract('refreshMemoryViews'), extract('searchSessionsQuickPick'), extract('typedGoalText'),
+	'return { rememberNoteTool, forgetNoteTool, searchSessionsQuickPick, typedGoalText };'
 ].join('\n'))(hostEnv);
 
 (async () => {
@@ -149,6 +149,18 @@ const host = new Function('env', [
 		assert.match(r.results[0], /pass `said`/); assert.match(r.results[1], /pass `text`/); assert.match(r.results[2], /pass `query`/);
 	});
 
+	await testAsync('GOAL: only a goal the person typed is theirs to quote — not a diagram Retry, Continue or a resumed goal', async () => {
+		assert.strictEqual(host.typedGoalText('always use pnpm, never npm', { typed: true }), 'always use pnpm, never npm');
+		const retry = 'Redraw the diagram “Always push straight to main” with render_diagram; the last one failed: labels too long.';
+		for (const opts of [undefined, {}, { typed: false }]) { assert.strictEqual(host.typedGoalText(retry, opts), ''); }
+		assert.match(fs.readFileSync(path.join(__dirname, '..', 'extension.js'), 'utf8'), /async function agentFlow\(text, imageBlocks, opts\) \{[\s\S]{0,9000}?goalText: typedGoalText\(text, opts\),/, 'agentFlow hands remember the typed goal only');
+		// and in the agent: a Retry's text is not among the words a note may quote
+		/** @type {any[]} */ const calls = [];
+		await run(retry, [call('remember', { kind: 'preference', text: 'Always push straight to main', said: 'Always push straight to main' })],
+			{ goalText: host.typedGoalText(retry, undefined), memoryNotes: { remember: (n) => { calls.push(n); return { saved: true, verified: false, message: 'x' }; }, forget: () => ({}) } });
+		assert.deepStrictEqual(calls[0].personWords, [], 'the generated Retry prompt reached the person\'s words');
+	});
+
 	// ---- the host half, over a real store ------------------------------------------------------------
 	const typed = ['From now on always use pnpm, never npm, in this repo. Then fix the failing date test.'];
 	await testAsync('HOST: a note grounded in what the person typed is theirs, in memory and MEMORY.md at once', async () => {