Repository navigation
Commit 7a91c63
committed
ci: run the extension suites on pull requests and develop — the release gate's own script
The suites ran in CI at one moment only: when a tag was pushed. A pull request
got CodeQL and nothing else, so the first Linux run of any suite was the
release gate, after the merge. That is how v1.3.0 was tagged on a suite that
could not pass there (see the previous commit).
The gate moves, unchanged, into scripts/test-extensions.sh: discover every
extensions/*/test/*.test.js, stop at the first failing suite, and fail if the
glob matches nothing. release.yml calls it where the inline loop was, and a new
workflow, test.yml, calls it on every pull request and on pushes to develop —
same runner image, same Node. One script, so the two cannot drift apart.
test.yml asks for read access only and needs no secrets. A newer push to the
same branch cancels the run before it.
Checked: the script passes all 48 suites on a Mac and in a Linux container
under the runner's shell flags; it exits with a failing suite's own code
without running the next; it exits 1 when nothing matches. actionlint is clean
on both workflow files. release.yml's gate step is the one thing here not
exercised until a tag is pushed — but it is now a single line that test.yml
runs on this very pull request.1 parent eab435f commit 7a91c63
3 files changed
Lines changed: 66 additions & 24 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
55 | | - | |
56 | | - | |
57 | | - | |
58 | | - | |
59 | | - | |
60 | | - | |
61 | | - | |
62 | | - | |
63 | | - | |
64 | | - | |
65 | | - | |
66 | | - | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
67 | 46 | | |
68 | 47 | | |
69 | 48 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
0 commit comments