Repository navigation
Commit e37ec59
committed
fix(levelcode-ai): #107 review — the shell prompt no longer says a stopped command changes nothing
The bug: the browser prompt told the model "A stopped command changes nothing." That holds for a
command stopped while it runs (its writes were only staged), but not after it has ended: a Stop, or the
agent's commandTimeout, while its file changes are in the review settles the run at once (the shell's
killRun), and what the review had already applied stays in Keep/Undo (shellCommit checks for the Stop
between changes). The model got "[stopped by user]" / "[timed out]" behind the shell's note "stopped
while the review of its file changes was going on ... it may still apply some of them", and a prompt
that contradicted it. host.js said the same thing in its SpawnOptions/ChildLike JSDoc.
The fix: the prompt says a command stopped while it runs changes nothing, and one stopped while its file
changes were being reviewed may have applied some of them (then in the Keep/Undo review), and that its
result says so. The JSDoc of `commit`'s control and of `kill` in host.js now describe the same thing
(comments only). The desktop prompt never had the sentence and is unchanged.
Test: shellSeam.test.js "BROWSER, shell registered: caps.shell is live, run_command is offered as what
it is" no longer pins the old sentence; it asserts it is gone and the new one is there. It fails on the
unfixed prompt and passes now. agentRunCommand.test.js is untouched.1 parent 1a47179 commit e37ec59
3 files changed
Lines changed: 13 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
81 | 81 | | |
82 | 82 | | |
83 | 83 | | |
84 | | - | |
| 84 | + | |
85 | 85 | | |
86 | 86 | | |
87 | 87 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
201 | 201 | | |
202 | 202 | | |
203 | 203 | | |
204 | | - | |
205 | | - | |
| 204 | + | |
| 205 | + | |
| 206 | + | |
206 | 207 | | |
207 | 208 | | |
208 | 209 | | |
209 | 210 | | |
210 | 211 | | |
211 | 212 | | |
212 | 213 | | |
213 | | - | |
214 | | - | |
215 | | - | |
| 214 | + | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
216 | 219 | | |
217 | 220 | | |
218 | 221 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
154 | 154 | | |
155 | 155 | | |
156 | 156 | | |
157 | | - | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
| 160 | + | |
158 | 161 | | |
159 | 162 | | |
160 | 163 | | |
| |||
0 commit comments