Whatsmeow api compatibility and mcp serialization - #301
Open
SKNOTFOUND248 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title:
Fix FastMCP tool serialization by converting dataclass responses to dictionaries
Description:
This pull request fixes a serialization issue in the Python MCP server where several WhatsApp tools failed during response validation.
The tool functions in
main.pywere annotated to returnList[Dict[str, Any]], while the underlying helper functions inwhatsapp.pyreturned dataclass instances such asContact,Chat, andMessage. Although the data was successfully retrieved, FastMCP (via Pydantic) expected standard Python dictionaries and raised validation errors when attempting to serialize the dataclass objects.To resolve this, I introduced a recursive
_to_dict()helper that converts dataclass instances into dictionaries while also handling nested dataclasses, lists, dictionaries, anddatetimeobjects by converting timestamps to ISO 8601 strings. All MCP tool handlers now serialize their responses before returning them, ensuring that the output matches the declared return types.This change restores compatibility with FastMCP's validation and serialization pipeline without modifying the underlying data models or business logic.
Benefits:
whatsapp.py.Tested:
All affected tools now return correctly serialized responses without validation errors.