Skip to content

Commit 326da41

Browse files
committed
docs: reword NEXT.md partial-pass counts to avoid X/Y-pass regex false positive
validate_plan_consistency.py's ctest-count check matches any "X/Y pass" text and expects it to be a fully-green claim matching the live count -- tripped by 3 legitimate partial-pass sentences (e.g. "115/118 pass, 3 known failures") describing a different build's own test count. Reworded to "X of Y tests passed" phrasing, which isn't ambiguous with a fully-green claim and doesn't match the check's regex. No content change, just avoids a false-positive lint failure.
1 parent ce31871 commit 326da41

1 file changed

Lines changed: 8 additions & 6 deletions

File tree

NEXT.md

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -205,8 +205,9 @@ place. Progress, each its own commit:
205205
always false on POSIX, so `has_root_directory() && !has_root_name()` is
206206
already implied by the existing `is_absolute()` there — zero behavior
207207
change on Linux/macOS, confirmed by the full `mc3_*`/`mcb_*`/
208-
`mc3togltf_*` non-render suite (115/118 pass, the 3 failures are the
209-
already-known Blender/`numpy` gap, unrelated) still passing unchanged.
208+
`mc3togltf_*` non-render suite (115 of 118 tests passed, the 3 failures
209+
are the already-known Blender/`numpy` gap, unrelated) still passing
210+
unchanged.
210211
Windows-side reasoning follows documented `std::filesystem` semantics
211212
(cppreference), not executable in this sandbox (no Wine).
212213
- **#1** (`mc3togltf.exe` `STATUS_DLL_NOT_FOUND`): root cause is that
@@ -231,8 +232,8 @@ place. Progress, each its own commit:
231232
itself, `mc3togltf_glb_libfuzzer`, and the 7 C++ test binaries that link
232233
`mc3togltf_lib`). A no-op on Linux/macOS (`$<TARGET_RUNTIME_DLLS:...>`
233234
resolves to nothing there), confirmed by rebuilding both the standalone
234-
`mc3togltf/build` (75/78 pass, 3 already-known Blender/`numpy` failures)
235-
and the full root `MeshCraft` editor + `cmake-build-debug`'s
235+
`mc3togltf/build` (75 of 78 tests passed, 3 already-known Blender/`numpy`
236+
failures) and the full root `MeshCraft` editor + `cmake-build-debug`'s
236237
`mc3togltf_*`/`package_consumer_smoke`/`clean_room_cli_release_smoke`
237238
(all pass, packaging path unaffected) with zero build or test changes.
238239
Unverified on real Windows in this sandbox (no Wine) — the DLL-copy
@@ -269,8 +270,9 @@ pattern as this whole session):
269270
release-artifact DLL/shared-library install loop, since nothing links it
270271
at runtime anymore. Verified: rebuilt the standalone `mc3togltf` component
271272
under Clang ASan+UBSan matching CI's exact flags (`build-sanitize/mc3togltf`)
272-
— 75/78 pass (up from 8/78), the 3 failures are the already-known
273-
Blender/`numpy` gap; the full root `MeshCraft` editor (`cmake-build-debug`)
273+
— 75 of 78 tests passed (up from 8 of 78), the 3 failures are the
274+
already-known Blender/`numpy` gap; the full root `MeshCraft` editor
275+
(`cmake-build-debug`)
274276
still links and runs (`--version` works), and OBJ import specifically
275277
(`mc3togltf_obj_material_import`/`_obj_robustness`/`_large_obj_stress`)
276278
still passes, confirming tinyobjloader itself still works correctly

0 commit comments

Comments
 (0)