Commit eb0cb3c
committed
fix: editor-sanitizer CI job actually used clang, not gcc as documented
An external review of tonight's work caught a real discrepancy: plan.md's
SYS-W11-09 writeup claims "the new sanitizer job [uses gcc/g++] too,
matching" the plain editor job, but `git log -S"editor-sanitizer"`
shows the job used clang/clang++ since its very first commit
(6e356c3) -- that claim was never actually applied to ci.yml. The
job has never had a fully green CI run: first blocked by unrelated
environment gaps (fixed separately tonight), now by SYS-W8-08's
sharp-runtime API mismatch, unrelated to compiler choice.
Fixed for real, not just in prose: switched the editor-sanitizer job's
CC/CXX to gcc-14/g++-14 (matching the plain editor job and the local
build-asan/ verification, which was already GCC-based, confirmed via
its CMakeCache.txt) and swapped clang for g++-14 in its apt-get install
list.
Downgraded SYS-W11-09 from [DONE] to [IN_PROGRESS] in plan.md: the code
fixes (heap-use-after-free, 4 leak fixtures, meshcraft_apply_sanitize()
wiring) are real and independently verified locally, but the CI job
itself was never actually verified green and had this real
misconfiguration. Also corrected NEXT.md's "Current priorities"
section, which had gone stale mid-session (still claiming "no Wine in
this sandbox" and "awaiting Windows run" hours after both were
resolved and documented further down the same file) -- exactly the
kind of internal contradiction the same review flagged.1 parent 5b98f69 commit eb0cb3c
3 files changed
Lines changed: 62 additions & 24 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
367 | 367 | | |
368 | 368 | | |
369 | 369 | | |
370 | | - | |
371 | | - | |
| 370 | + | |
| 371 | + | |
| 372 | + | |
| 373 | + | |
| 374 | + | |
| 375 | + | |
| 376 | + | |
| 377 | + | |
| 378 | + | |
| 379 | + | |
| 380 | + | |
372 | 381 | | |
373 | 382 | | |
374 | 383 | | |
| |||
414 | 423 | | |
415 | 424 | | |
416 | 425 | | |
417 | | - | |
| 426 | + | |
418 | 427 | | |
419 | 428 | | |
420 | 429 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
30 | 30 | | |
31 | 31 | | |
32 | 32 | | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
37 | | - | |
38 | | - | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
51 | 63 | | |
52 | 64 | | |
53 | 65 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
375 | 375 | | |
376 | 376 | | |
377 | 377 | | |
378 | | - | |
| 378 | + | |
379 | 379 | | |
380 | 380 | | |
381 | 381 | | |
| |||
444 | 444 | | |
445 | 445 | | |
446 | 446 | | |
447 | | - | |
448 | | - | |
| 447 | + | |
| 448 | + | |
449 | 449 | | |
450 | 450 | | |
451 | 451 | | |
452 | 452 | | |
453 | 453 | | |
| 454 | + | |
| 455 | + | |
| 456 | + | |
| 457 | + | |
| 458 | + | |
| 459 | + | |
| 460 | + | |
| 461 | + | |
| 462 | + | |
| 463 | + | |
| 464 | + | |
| 465 | + | |
| 466 | + | |
| 467 | + | |
| 468 | + | |
| 469 | + | |
| 470 | + | |
454 | 471 | | |
455 | 472 | | |
456 | 473 | | |
| |||
0 commit comments