refactor: extract status bar

Author: robertvokac

NEXT.md

@@ -20,7 +20,7 @@ replacing the former flat `src/MeshCraft/MeshCraftApplication_*.cpp` layout.
 `MeshCraft::Application::MeshCraftApplication`; the old public include remains
 a compatibility forwarder. Actual UI components currently cover Validation,
 Registry results, Toolbar tools/display/snap-surface/proportional/grid controls,
-Properties delegation, Camera Preset Overlay, Gizmo Drag Overlay, Stats Overlay, Measurement Overlay, and the View-menu panel/overlay/direction/focus/
+Properties delegation, Camera Preset Overlay, Gizmo Drag Overlay, Stats Overlay, Measurement Overlay, Status Bar, and the View-menu panel/overlay/direction/focus/
 Camera-Bookmarks/Walk-Mode/Bloom-SSAO presentation, plus the Add/CSG and Help menu
 presentation and the Edit-history, clipboard, object-action, and
 selection-action groups, the Select-by-Type/Tag/Material, Align-Selection,
@@ -105,7 +105,7 @@ before when explicitly requested (`SYS-W14-##` rows).
 ## 2. Current status
 
 - **Last full build: clean after the current Phase 13 File-open-recent,
-  View-Bloom/SSAO, SSAO-regression, Camera Preset Overlay, Gizmo Drag Overlay, Stats Overlay, and Measurement Overlay slices.** Testing is enabled in the current Ninja Release tree, and
+  View-Bloom/SSAO, SSAO-regression, Camera Preset Overlay, Gizmo Drag Overlay, Stats Overlay, Measurement Overlay, and Status Bar slices.** Testing is enabled in the current Ninja Release tree, and
   `CCACHE_DISABLE=1 cmake --build b-release -j4` linked all targets successfully
   on EASYGL. Alternate-backend runtime qualification remains blocked.
 - **Tests:** the fresh Release tree registers 182 tests. All passed again after
@@ -174,7 +174,7 @@ before when explicitly requested (`SYS-W14-##` rows).
   application into `MeshCraft::Application`, organized implementation files
   by application/UI ownership, and is extracting UI presentation through
   narrow contexts. Validation, Registry results, Toolbar controls, Properties
-  delegation, Camera Preset Overlay, Gizmo Drag Overlay, Stats Overlay, Measurement Overlay, and the View-menu directions/focus/overlays/panels/
+  delegation, Camera Preset Overlay, Gizmo Drag Overlay, Stats Overlay, Measurement Overlay, Status Bar, and the View-menu directions/focus/overlays/panels/
   Camera-Bookmarks/Walk-Mode/Bloom-SSAO presentation, plus the Add/CSG and Help menu
   presentation and the Edit-history, clipboard, object-action, and
   selection-action groups, the Select-by-Type/Tag/Material, Align-Selection,
@@ -249,6 +249,14 @@ before when explicitly requested (`SYS-W14-##` rows).
   point hint, and lower-left result panel without access to the camera,
   document, or mutation paths. Its header compiles independently and focused
   `mc3_commands` plus Xvfb `smoke_test` regressions passed.
+- **Recently implemented (2026-07-25):** the bottom bar is now
+  `Application::UI::StatusBar`. The application prepares either a timed
+  notification or a scene-summary snapshot and supplies validation metadata
+  plus the sole callback to open the existing panel. Notification lifetime,
+  document traversal, selection, and validation-panel state remain in the
+  application. The component preserves the colors, selected-object text,
+  validation indicator, tooltip, and click action; its header compiles
+  independently and focused `mc3_commands` plus Xvfb `smoke_test` passed.
 - **Recently implemented (2026-07-20 through 2026-07-25):** all 7
   raw-OpenGL(ES)-vs-CNA migrations, `AUD-082` through `AUD-088` — full
   detail with file:line evidence and
@@ -850,7 +858,7 @@ git stash pop && cmake --build b-release -j4 --target <affected-target>
 No actionable follow-up audit task remains: `AUD-089` through `AUD-092` are
 complete, while Android (`AUD-042`) is environment/owner deferred.
 `SYS-W3-01` has 12 completed subsystem phases and an active Phase 13 for
-application/UI ownership. The authorized Camera Bookmarks, Camera Preset Overlay, Gizmo Drag Overlay, Stats Overlay, Measurement Overlay, Walk Mode, View
+application/UI ownership. The authorized Camera Bookmarks, Camera Preset Overlay, Gizmo Drag Overlay, Stats Overlay, Measurement Overlay, Status Bar, Walk Mode, View
 Bloom/SSAO, Help, Add/CSG, Edit-history, Edit-clipboard, and Edit-object-actions
 menu slices are implemented and verified, together with Edit-selection-actions,
 Edit-select-by-type/tag/material, Edit-copy-properties, Edit-grouping,
@@ -1113,10 +1121,19 @@ one item does not authorize the next.
    retains measurement state and world-to-screen projection, passing only
    projected points, values, and viewport bounds to the component.
 
-5. **Fresh post-overlay boundary audit.** Identify the next coherent
-   presentation-only cluster before changing `MeshCraftApplication`; avoid a
-   broad `Overlays.cpp` extraction or a context that exposes document/renderer
-   internals.
+5. **Fourth post-overlay follow-up — complete.** The bottom bar is now
+   `Application::UI::StatusBar`; application code constructs its notification
+   or scene-summary snapshot and retains the validation-panel transition.
+
+### Final post-overlay audit (2026-07-25)
+
+No additional safe narrow extraction remains. `drawDialogs()` is composed of
+stateful workflows with their own buffers, transitions, undo/document effects,
+and keyboard routes; `drawPanelSplitters()` owns global panel geometry; and
+`drawShadowDebugOverlay()` carries a live renderer texture token plus shadow
+light lookup. Splitting any one without a new, broader ownership design would
+create a god-context or relocate application state into UI. The next work should
+be a separately scoped subsystem, not another mechanical `Overlays.cpp` slice.
 
 ### Tracked work that is not implementation-ready
 

include/MeshCraft/Application/UI/StatusBar.hpp

@@ -0,0 +1,29 @@
+#pragma once
+
+#include <functional>
+#include <string_view>
+
+namespace MeshCraft::Application::UI {
+
+struct StatusBarContext {
+    int screenWidth;
+    int screenHeight;
+    int statusHeight;
+    bool hasNotification;
+    bool notificationIsError;
+    std::string_view notificationMessage{""};
+    int totalObjectCount;
+    int selectedObjectCount;
+    std::string_view selectedObjectName{""};
+    bool hasValidation;
+    int validationEntryCount;
+    std::string_view validationSource{""};
+    std::function<void()> openValidation;
+};
+
+class StatusBar final {
+public:
+    static void draw(const StatusBarContext& context);
+};
+
+} // namespace MeshCraft::Application::UI

plan.md

@@ -164,7 +164,7 @@ still internally consistent.
    research pass.
 6. **SYS-W3-01 (P2/W3), Phase 13 is active:** application/UI ownership is
    being reduced one narrow presentation slice at a time. The authorized
-   Camera Bookmarks, Camera Preset Overlay, Gizmo Drag Overlay, Stats Overlay, Measurement Overlay, Walk Mode, View Bloom/SSAO, Help, Add/CSG, Edit-history,
+   Camera Bookmarks, Camera Preset Overlay, Gizmo Drag Overlay, Stats Overlay, Measurement Overlay, Status Bar, Walk Mode, View Bloom/SSAO, Help, Add/CSG, Edit-history,
    Edit-clipboard,
    Edit-object-actions, Edit-selection-actions, Edit-select-by-type,
    Edit-select-by-tag/material, Edit-copy-properties, Edit-grouping,
@@ -194,7 +194,12 @@ still internally consistent.
    traversal and renderer statistics stay application-owned. The next audit
    moved 2D measurement rendering into `Application::UI::MeasurementOverlay`;
    world-to-screen projection and measurement state stay application-owned.
-   The next Phase 13 action is a fresh narrow boundary audit.
+   The final narrow overlay slice moved the bottom status bar into
+   `Application::UI::StatusBar`; scene summary calculation, notification
+   lifecycle, and validation-panel state remain application-owned. A final
+   audit found no additional safe narrow boundary: the remaining dialogs are
+   stateful workflows, splitters own global layout, and Shadow Debug carries a
+   live render resource token.
 
 ---
 
@@ -638,6 +643,10 @@ _All items in this workstream are DONE — archived to [`docs/history/plan_20260
   point markers, hint, and result panel. `Overlays.cpp` retains the cached
   view-projection calculation and all measurement state, passing projected
   points, immutable coordinates, distance, and viewport bounds by value.
+  `Application::UI::StatusBar` owns only bottom-bar presentation. The
+  application constructs the notification or scene-summary snapshot and retains
+  notification lifetime, scene traversal, selection, validation data, and the
+  sole callback that opens the existing validation panel.
   The bookmark state remains the already-extracted
   `Editor::CameraBookmarks`; a `CameraBookmarksContext` exposes only the
   read-only slots plus Save/Restore callbacks, leaving camera mutation and
@@ -814,7 +823,7 @@ _All items in this workstream are DONE — archived to [`docs/history/plan_20260
   File-export-selection, File-export-GLB, File-export-OBJ, File-save,
   File-save-as, File-import-OBJ, File-new, File-open, File-open-recent, and
   File-exit slices, the Bloom/SSAO controls, CameraPresetOverlay, and
-  GizmoDragOverlay, StatsOverlay, and MeasurementOverlay,
+  GizmoDragOverlay, StatsOverlay, MeasurementOverlay, and StatusBar,
   each incremental Release link and the same 147/147 + 35/35 partitions pass
   again.
   For the current MenuBar slices, the public UI header also compiles as a
@@ -827,7 +836,9 @@ _All items in this workstream are DONE — archived to [`docs/history/plan_20260
   and callbacks. GizmoDragOverlay follows the same boundary for a pure
   read-only drag snapshot, and StatsOverlay does so for the renderer-derived
   top-right summary. MeasurementOverlay similarly consumes only projected
-  ruler values. The next Phase 13 action is a fresh narrow-boundary audit.
+  ruler values, while StatusBar presents the application-computed bottom
+  summary. No further safe narrow Phase 13 extraction remains after the final
+  overlay audit.
   **SYS-W3-01 roadmap status after this session's investigation round:**
   Phases 1–12 done (Keybindings, Preferences, MacroRecorder, UndoManager,
   animation-override computation, WalkController, AudioPreview,

src/MeshCraft/Application/UI/Overlays.cpp

@@ -3,6 +3,7 @@
 #include "MeshCraft/Application/UI/GizmoDragOverlay.hpp"
 #include "MeshCraft/Application/UI/MeasurementOverlay.hpp"
 #include "MeshCraft/Application/UI/StatsOverlay.hpp"
+#include "MeshCraft/Application/UI/StatusBar.hpp"
 #include "MeshCraft/MeshCraftPrivate.hpp"
 #include "MeshCraft/EditorAlgorithms.hpp"
 #include "MeshCraft/Scene/SceneHierarchyPanel.hpp"
@@ -165,59 +166,37 @@ void MeshCraftApplication::drawStatsOverlay(int screenW, [[maybe_unused]] int sc
 
 void MeshCraftApplication::drawStatusBar(int screenW, int screenH)
 {
-    (void)screenW;
-    // Status bar (bottom)
-    // -----------------------------------------------------------------------
-    ImGui::SetNextWindowPos(ImVec2(0, static_cast<float>(screenH - kStatusH)));
-    ImGui::SetNextWindowSize(ImVec2(static_cast<float>(screenW), static_cast<float>(kStatusH)));
-    ImGui::PushStyleVar(ImGuiStyleVar_WindowPadding, ImVec2(6, 3));
-    ImGui::PushStyleColor(ImGuiCol_WindowBg, ImVec4(0.086f, 0.094f, 0.176f, 1.0f));
-    ImGui::Begin("##statusbar", nullptr,
-        ImGuiWindowFlags_NoTitleBar | ImGuiWindowFlags_NoResize | ImGuiWindowFlags_NoMove |
-        ImGuiWindowFlags_NoBringToFrontOnFocus | ImGuiWindowFlags_NoScrollbar |
-        ImGuiWindowFlags_NoScrollWithMouse | ImGuiWindowFlags_NoSavedSettings);
-    {
-        // Timed notification takes priority; falls back to scene info
-        if (statusNotification_.active()) {
-            ImVec4 col = statusNotification_.isError() ? ImVec4(1.0f, 0.45f, 0.45f, 1.0f)
-                                                        : ImVec4(0.55f, 1.0f, 0.55f, 1.0f);
-            ImGui::TextColored(col, "%s", statusNotification_.message().c_str());
-        } else {
-            int totalObjs = 0;
-            std::function<void(const std::vector<std::shared_ptr<Mc3::Mc3Object>>&)> countAll =
-                [&](const std::vector<std::shared_ptr<Mc3::Mc3Object>>& list) {
-                    totalObjs += static_cast<int>(list.size());
-                    for (const auto& o : list) countAll(o->children);
-                };
-            countAll(document_.objects);
-            int selCount = static_cast<int>(selection_.selection().size());
-            if (selCount > 0) {
-                const std::string& selName = selection_.selection().front()->name;
-                ImGui::Text("%d objects | %d selected | %s", totalObjs, selCount, selName.c_str());
-            } else {
-                ImGui::Text("%d objects", totalObjs);
-            }
-        }
-
-        // SYS-W14-02: small clickable indicator for the last load/save/export's
-        // validation findings -- otherwise SYS-W1-01's diagnostics are console-only.
-        if (!lastValidation_.empty()) {
-            const std::string label =
-                "[!] " + std::to_string(lastValidation_.entries.size()) + " validation note(s)";
-            ImVec2 textSize = ImGui::CalcTextSize(label.c_str());
-            ImGui::SameLine(ImGui::GetWindowWidth() - textSize.x - 12.0f);
-            ImGui::TextColored(ImVec4(1.0f, 0.75f, 0.35f, 1.0f), "%s", label.c_str());
-            if (ImGui::IsItemClicked()) showValidationPanel_ = true;
-            if (ImGui::IsItemHovered())
-                ImGui::SetTooltip("From: %s\nClick to open the Validation panel",
-                                   lastValidationSource_.c_str());
-        }
-    }
-    ImGui::End();
-    ImGui::PopStyleColor();
-    ImGui::PopStyleVar();
-
-
+    const bool hasNotification = statusNotification_.active();
+    int totalObjects = 0;
+    int selectedObjects = 0;
+    std::string_view selectedObjectName;
+    if (!hasNotification) {
+        std::function<void(const std::vector<std::shared_ptr<Mc3::Mc3Object>>&)> countAll =
+            [&](const std::vector<std::shared_ptr<Mc3::Mc3Object>>& list) {
+                totalObjects += static_cast<int>(list.size());
+                for (const auto& object : list)
+                    countAll(object->children);
+            };
+        countAll(document_.objects);
+        selectedObjects = static_cast<int>(selection_.selection().size());
+        if (selectedObjects > 0)
+            selectedObjectName = selection_.selection().front()->name;
+    }
+    UI::StatusBar::draw({
+        .screenWidth = screenW,
+        .screenHeight = screenH,
+        .statusHeight = kStatusH,
+        .hasNotification = hasNotification,
+        .notificationIsError = statusNotification_.isError(),
+        .notificationMessage = statusNotification_.message(),
+        .totalObjectCount = totalObjects,
+        .selectedObjectCount = selectedObjects,
+        .selectedObjectName = selectedObjectName,
+        .hasValidation = !lastValidation_.empty(),
+        .validationEntryCount = static_cast<int>(lastValidation_.entries.size()),
+        .validationSource = lastValidationSource_,
+        .openValidation = [this] { showValidationPanel_ = true; },
+    });
 }
 
 void MeshCraftApplication::drawDialogs()

src/MeshCraft/Application/UI/StatusBar.cpp

@@ -0,0 +1,55 @@
+#include "MeshCraft/Application/UI/StatusBar.hpp"
+
+#include <imgui.h>
+
+#include <string>
+
+namespace MeshCraft::Application::UI {
+
+void StatusBar::draw(const StatusBarContext& context)
+{
+    ImGui::SetNextWindowPos(ImVec2(0, static_cast<float>(context.screenHeight - context.statusHeight)));
+    ImGui::SetNextWindowSize(
+        ImVec2(static_cast<float>(context.screenWidth), static_cast<float>(context.statusHeight)));
+    ImGui::PushStyleVar(ImGuiStyleVar_WindowPadding, ImVec2(6, 3));
+    ImGui::PushStyleColor(ImGuiCol_WindowBg, ImVec4(0.086f, 0.094f, 0.176f, 1.0f));
+    ImGui::Begin("##statusbar", nullptr,
+        ImGuiWindowFlags_NoTitleBar | ImGuiWindowFlags_NoResize | ImGuiWindowFlags_NoMove |
+        ImGuiWindowFlags_NoBringToFrontOnFocus | ImGuiWindowFlags_NoScrollbar |
+        ImGuiWindowFlags_NoScrollWithMouse | ImGuiWindowFlags_NoSavedSettings);
+
+    if (context.hasNotification) {
+        const ImVec4 color = context.notificationIsError
+            ? ImVec4(1.0f, 0.45f, 0.45f, 1.0f)
+            : ImVec4(0.55f, 1.0f, 0.55f, 1.0f);
+        ImGui::TextColored(color, "%.*s", static_cast<int>(context.notificationMessage.size()),
+                           context.notificationMessage.data());
+    } else if (context.selectedObjectCount > 0) {
+        ImGui::Text("%d objects | %d selected | %.*s", context.totalObjectCount,
+                    context.selectedObjectCount, static_cast<int>(context.selectedObjectName.size()),
+                    context.selectedObjectName.data());
+    } else {
+        ImGui::Text("%d objects", context.totalObjectCount);
+    }
+
+    if (context.hasValidation) {
+        const std::string label =
+            "[!] " + std::to_string(context.validationEntryCount) + " validation note(s)";
+        const ImVec2 textSize = ImGui::CalcTextSize(label.c_str());
+        ImGui::SameLine(ImGui::GetWindowWidth() - textSize.x - 12.0f);
+        ImGui::TextColored(ImVec4(1.0f, 0.75f, 0.35f, 1.0f), "%s", label.c_str());
+        if (ImGui::IsItemClicked())
+            context.openValidation();
+        if (ImGui::IsItemHovered()) {
+            ImGui::SetTooltip("From: %.*s\nClick to open the Validation panel",
+                              static_cast<int>(context.validationSource.size()),
+                              context.validationSource.data());
+        }
+    }
+
+    ImGui::End();
+    ImGui::PopStyleColor();
+    ImGui::PopStyleVar();
+}
+
+} // namespace MeshCraft::Application::UI