Commit 3a417d6
committed
fix(core,net-http,text-json): a default-constructed exception carries .NET's fallback message (#2323)
System::Exception{} reported an empty message. .NET's is
`_message ?? SR.Format(SR.Exception_WasThrown, GetClassName())` (Exception.cs:61,65)
-- "Exception of type '{0}' was thrown." (Strings.resx:2333) -- with {0} the runtime
type name.
BOTH RECORDED BLOCKERS ARE RESOLVED, and the second dissolves rather than being
worked around.
1. The exact resource text was unreadable with /rv absent. It is readable now.
2. {0} is GetType(), which is reflection this port permanently lacks. But .NET
computes the fallback LAZILY only so that _message can stay null for
serialization; the observable is identical if the constructor just stores it,
which is what a hundred subclasses in this repository already do. So {0} is
resolved STATICALLY, at each site, by the one entity that knows the answer:
the type itself. No reflection, no new virtual, no layout change, no signature
change, no optional.
Hard-coding the base string and letting subclasses inherit it was the option the
review rejected, and rightly: a message naming the WRONG type is a lie, where an
empty one is merely an absence.
THE REVIEW'S PREMISE MEASUREMENT WAS WRONG. It recorded that "18 subclasses supply
a NON-EMPTY default message and exactly ONE type does not -- System::Exception
itself", so the blast radius was the base constructed directly. Re-measured across
all 103 exception subclasses: THREE reach the base fallback. `= default` on a
derived exception default-constructs its base, and two types spell it that way --
HttpRequestException (.NET's is `{ }`, HttpRequestException.cs:10-11) and
JsonException (`: base() { }`, JsonException.cs:78, with Message overridden as
`_message ?? base.Message`). Both are given the message .NET produces for them,
naming themselves.
An EXPLICITLY empty message stays empty, which is also .NET: its fallback fires on
a null message, and `new Exception("")` has Message == "".
THE GUARD. The cost of static resolution is that a future subclass written as
`= default` would silently report System.Exception.
ExceptionFallbackMessageTests.NoOtherExceptionInheritsTheBaseFallback asserts that
a representative set carries neither the base string nor an empty message, so such
a subclass is caught here rather than discovered downstream. The two out-of-module
rows live in modules/net-http/tests and modules/text-json/tests, because Core.Base
depends on neither and a test is not a reason to add a public component edge
(#2354's rule). The module graph is unchanged at 41/92.
DOWNSTREAM IS NOT EMPTY, which is the point of measuring it. mobile-eggbert: zero
sites. cna: FIVE exception types whose default constructors chain to
System::Exception() -- GameUpdateRequiredException, GuideAlreadyVisibleException,
GamerPrivilegeException, GamerServicesNotAvailableException and NetworkException,
each at modules/gamer-services/src/Xna/<Type>.cpp lines 7 and 25 -- whose default
message now names the WRONG type, plus SIX tests asserting EXPECT_STREQ("",
ex.what()) that will fail. cna may be read but not edited without a per-action
instruction, so this is recorded as ticket #2377, not performed. The correct
downstream repair is the one applied here: give each of the six its own message.
Three pins inverted (two in Core.Base, one in the integration suite). Three
mutations, all caught.
Gate: 17,318 run, 17,318 passed, 0 failed, 0 skipped across 38 executables, GREEN.
docs/Migration-ExceptionFallbackMessage.md1 parent 2297b7c commit 3a417d6
11 files changed
Lines changed: 290 additions & 9 deletions
File tree
- docs
- modules
- core
- src/System
- tests/System
- net-http
- include/System/Net/Http
- tests/System/Net
- text-json
- include/System/Text/Json
- tests/System/Text/Json
- tests/integration/System
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
12 | 28 | | |
13 | | - | |
| 29 | + | |
14 | 30 | | |
15 | 31 | | |
16 | 32 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
5 | 12 | | |
6 | 13 | | |
7 | 14 | | |
| |||
14 | 21 | | |
15 | 22 | | |
16 | 23 | | |
17 | | - | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
18 | 27 | | |
19 | | - | |
| 28 | + | |
| 29 | + | |
20 | 30 | | |
21 | 31 | | |
22 | 32 | | |
| |||
63 | 73 | | |
64 | 74 | | |
65 | 75 | | |
| 76 | + | |
| 77 | + | |
| 78 | + | |
| 79 | + | |
| 80 | + | |
| 81 | + | |
| 82 | + | |
| 83 | + | |
| 84 | + | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
| 119 | + | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
| 126 | + | |
| 127 | + | |
| 128 | + | |
| 129 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
48 | | - | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
49 | 52 | | |
50 | | - | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
51 | 56 | | |
52 | 57 | | |
53 | 58 | | |
| |||
Lines changed: 13 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
27 | 39 | | |
28 | 40 | | |
29 | 41 | | |
| |||
Lines changed: 32 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
Lines changed: 11 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
27 | 37 | | |
28 | 38 | | |
29 | 39 | | |
| |||
Lines changed: 26 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
Binary file not shown.
0 commit comments