Skip to content

Commit 7e3f923

Browse files
committed
docs(SAMPLES-DEC-008): correct the float probe's value count, 47 -> 55
Re-running the probe to restore the source the docs cite showed the count was wrong: it sweeps 55 values (17 named floats, a full Matrix.Identity and a placed transform at 16 each, and 6 doubles), not 47. The result is unchanged -- 55/55 round-trip bit-for-bit -- but a cited number that does not match what the cited program prints is worse than no number.
1 parent 5551b25 commit 7e3f923

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

docs/XmlSerializationScope.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -165,9 +165,9 @@ four-space form.
165165

166166
## Float round-trip: measured, not assumed
167167

168-
`build-probe/xml_probe_float_roundtrip.cpp` swept 47 values — a full `Matrix.Identity`, a placed
168+
`build-probe/xml_probe_float_roundtrip.cpp` swept 55 values — a full `Matrix.Identity`, a placed
169169
entity transform, `0.1f`, `1/3`, denormals, `epsilon`, `±INF`, `NaN`, `float`/`double` extremes —
170-
through `XmlConvert::ToString``ToSingle`/`ToDouble` and compared **bit patterns**. 47/47
170+
through `XmlConvert::ToString``ToSingle`/`ToDouble` and compared **bit patterns**. 55/55
171171
round-tripped exactly. This is why the module adds no float-formatting logic of its own: the
172172
capability already existed, tested and audited, in `modules/xml`.
173173

modules/xml-serialization/include/System/Xml/Serialization/detail/XmlLeafConvert.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,7 @@ namespace System::Xml::Serialization::detail {
7474
*
7575
* Delegates entirely to `System::Xml::XmlConvert`, which is where the float/double
7676
* round-trip work already lives (probed empirically in `build-probe/
77-
* xml_probe_float_roundtrip.cpp`: 47/47 values -- including a full `Matrix.Identity` and a
77+
* xml_probe_float_roundtrip.cpp`: 55/55 values -- including a full `Matrix.Identity` and a
7878
* placed-entity transform -- round-tripped bit-for-bit through `XmlConvert::ToString`/
7979
* `ToSingle`/`ToDouble`). This header adds no float-formatting logic of its own; it only
8080
* dispatches to it by type, which is the entire reason Opus's "risk #1" turned out to be

0 commit comments

Comments
 (0)