Commit cd45b1a
committed
docs(uri): #2003 resolves with NO change -- the approval it asked for points away from .NET
#2003 asked for approval to "make System::Uri reject an embedded NUL anywhere in the URI string
with UriFormatException, ACCEPTING THAT THE .NET BEHAVIOUR IT MATCHES COULD NOT BE RE-MEASURED
IN THIS ENVIRONMENT". /rv/tmp/runtime is present, so it was re-measured, and it says the
opposite. The approval must not be sought. No production statement changed.
- UriHelper.s_notSafeForUnescapeChars lists U+0000 through U+001F explicitly, so a NUL is
never unescaped back from %00 -- it is carried, not refused.
- Uri.TryCreateThis (UriExt.cs:30-70) has NO whole-string character precheck at all; the only
rejection paths are the scheme, the host and the port.
- A control character in the path, query or fragment is percent-ESCAPED during
canonicalisation. The data survives; only its rendering differs.
THIS PORT ALREADY MATCHES. Rejection is confined to scheme, host and port in both runtimes. The
one difference -- raw rather than %00 -- is the already-declared no-percent-encoding boundary
(plan 15.1), not a second divergence.
TWO PREMISE CORRECTIONS, both measured:
1. The title says a NUL crosses "into every component". It does not any more: #2359 gave the
host .NET's DNS character set four days after #2003 was written, and a NUL is outside it
exactly as a space is.
2. "No truncation" was asserted of the STRING and never of the component ACCESSORS. It holds
for those too, and every row now asserts a LENGTH -- a first probe of this ticket printed
the accessors with %s and appeared to show truncation that was not there, which is exactly
the shape a byte count catches and a rendered string does not.
THE DECISION IS ENFORCED RATHER THAN WRITTEN DOWN. Two changes were built and run before being
reverted: truncating the input at the first NUL is caught by 4 tests, and THE REPAIR THE TICKET
PROPOSED -- reject anywhere with UriFormatException -- is caught by 3. If that approval were
ever granted and implemented, the suite fails immediately and names this decision.
Gate: 17,386 run, 17,386 passed, 0 failed, 0 skipped across 38 executables (+1, in
SharpRuntimeTests_Uri, 278 -> 279). Built in build/ with --parallel 2. No behaviour changed, so
nothing to migrate downstream.
docs/Migration-UriEmbeddedNul.md1 parent af0ddea commit cd45b1a
4 files changed
Lines changed: 135 additions & 10 deletions
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| 69 | + | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1371 | 1371 | | |
1372 | 1372 | | |
1373 | 1373 | | |
1374 | | - | |
| 1374 | + | |
1375 | 1375 | | |
1376 | | - | |
1377 | | - | |
1378 | | - | |
1379 | | - | |
1380 | | - | |
1381 | | - | |
1382 | | - | |
1383 | | - | |
| 1376 | + | |
| 1377 | + | |
| 1378 | + | |
| 1379 | + | |
| 1380 | + | |
| 1381 | + | |
| 1382 | + | |
| 1383 | + | |
| 1384 | + | |
| 1385 | + | |
| 1386 | + | |
| 1387 | + | |
| 1388 | + | |
| 1389 | + | |
| 1390 | + | |
| 1391 | + | |
| 1392 | + | |
| 1393 | + | |
| 1394 | + | |
| 1395 | + | |
| 1396 | + | |
| 1397 | + | |
| 1398 | + | |
| 1399 | + | |
| 1400 | + | |
| 1401 | + | |
| 1402 | + | |
1384 | 1403 | | |
1385 | 1404 | | |
1386 | 1405 | | |
| |||
1428 | 1447 | | |
1429 | 1448 | | |
1430 | 1449 | | |
| 1450 | + | |
| 1451 | + | |
| 1452 | + | |
| 1453 | + | |
| 1454 | + | |
| 1455 | + | |
| 1456 | + | |
| 1457 | + | |
| 1458 | + | |
| 1459 | + | |
| 1460 | + | |
| 1461 | + | |
| 1462 | + | |
| 1463 | + | |
| 1464 | + | |
| 1465 | + | |
| 1466 | + | |
| 1467 | + | |
| 1468 | + | |
| 1469 | + | |
| 1470 | + | |
| 1471 | + | |
| 1472 | + | |
| 1473 | + | |
| 1474 | + | |
| 1475 | + | |
| 1476 | + | |
| 1477 | + | |
| 1478 | + | |
| 1479 | + | |
| 1480 | + | |
| 1481 | + | |
| 1482 | + | |
| 1483 | + | |
1431 | 1484 | | |
1432 | 1485 | | |
1433 | 1486 | | |
| |||
Binary file not shown.
0 commit comments