Conversation
The oauth/src/lib.rs call sites this PR originally targeted were relocated by a later, already-merged refactor (build_token() extraction). Same clippy::implicit_clone lint, same fix, reapplied at the new locations; metadata-crate fixes are the original diff.
m00grin
marked this pull request as draft
September 2, 2026 18:09
m00grin
force-pushed
the
chore-batch-housekeeping
branch
from
September 2, 2026 18:15
cd76658 to
edd21a7
Compare
m00grin
marked this pull request as ready for review
September 2, 2026 18:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I'm sending this
I'm a recent contributor to raspotify, a couple of PRs merged there this
week, so librespot staying healthy matters to me. The PR queue has grown
large, so I spent some time checking how much of it is safely combinable.
This is the mechanical end of it: CI config, dependency bumps, lint
cleanup. No behavior changes, no design decisions, nothing here has an
open question on its original thread.
What this is
A cherry-picked, authorship-preserved combination of 8 already-open PRs,
one commit per original PR (per CONTRIBUTING.md's guidance against
bundling multiple changes into one commit). Each commit is unmodified
from its original author except where noted,
git blamestill points tothem, not me:
async-traitdependencycrypto-commonto v0.1.7implicit_clonelint (see note below)vergengit values are unavailableshuffle_vectest (closes Sporadic test failure:shuffle_vec::test::test_shuffle_with_first#1668,already been through a round of Copilot review that caught a real
compile-breaking typo and a real infinite-loop risk, both fixed)
quinn-prototo v0.11.15 (RUSTSEC, closes RUSTSEC-2026-0037: Denial of service in Quinn endpoints #1697)cargo auditworkflowNote on #1667: its
oauth/src/lib.rshunk targeted code sincerestructured by the
build_token()extraction ondev. Reapplied thesame fix at the call sites it moved to, rather than drop it.
Verified on current
devcargo fmt --all -- --check, cleancargo clippy --workspace --all-targets -- -D warnings, zero warnings(rustls and native-tls both checked)
cargo test --workspace, all green, including the flaky test chore: fix shuffle vec test #1670 targetscargo test(stable/1.85 ×ubuntu/macos/windows), and cross builds (armv7/aarch64/riscv64gc)
Not my call
Closing #1637/#1666/#1667/#1669/#1670/#1671/#1696/#1698 in favor of this,
if useful, is your decision. Happy to split it apart, drop pieces, or have
you cherry-pick from it directly instead of merging as-is. If it's not
useful, no worries, close it.