Skip to content

chore: batch housekeeping — CI, lint, deps (8 independently-authored PRs) - #1754

Open
m00grin wants to merge 8 commits into
librespot-org:devfrom
m00grin:chore-batch-housekeeping
Open

m00grin wants to merge 8 commits into
librespot-org:devfrom
m00grin:chore-batch-housekeeping

Conversation

@m00grin

@m00grin m00grin commented Sep 2, 2026

Copy link
Copy Markdown

Why I'm sending this

I'm a recent contributor to raspotify, a couple of PRs merged there this
week, so librespot staying healthy matters to me. The PR queue has grown
large, so I spent some time checking how much of it is safely combinable.
This is the mechanical end of it: CI config, dependency bumps, lint
cleanup. No behavior changes, no design decisions, nothing here has an
open question on its original thread.

What this is

A cherry-picked, authorship-preserved combination of 8 already-open PRs,
one commit per original PR (per CONTRIBUTING.md's guidance against
bundling multiple changes into one commit). Each commit is unmodified
from its original author except where noted, git blame still points to
them, not me:

Note on #1667: its oauth/src/lib.rs hunk targeted code since
restructured by the build_token() extraction on dev. Reapplied the
same fix at the call sites it moved to, rather than drop it.

Verified on current dev

  • cargo fmt --all -- --check, clean
  • cargo clippy --workspace --all-targets -- -D warnings, zero warnings
    (rustls and native-tls both checked)
  • cargo test --workspace, all green, including the flaky test chore: fix shuffle vec test #1670 targets
  • Full CI matrix green: fmt, clippy, native cargo test (stable/1.85 ×
    ubuntu/macos/windows), and cross builds (armv7/aarch64/riscv64gc)

Not my call

Closing #1637/#1666/#1667/#1669/#1670/#1671/#1696/#1698 in favor of this,
if useful, is your decision. Happy to split it apart, drop pieces, or have
you cherry-pick from it directly instead of merging as-is. If it's not
useful, no worries, close it.

@m00grin
m00grin marked this pull request as draft September 2, 2026 18:09
@m00grin m00grin changed the title chore: batch housekeeping — CI, lint, deps, docs (9 independently-authored PRs) chore: batch housekeeping — CI, lint, deps (8 independently-authored PRs) Sep 2, 2026
@m00grin
m00grin force-pushed the chore-batch-housekeeping branch from cd76658 to edd21a7 Compare September 2, 2026 18:15
@m00grin
m00grin marked this pull request as ready for review September 2, 2026 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RUSTSEC-2026-0037: Denial of service in Quinn endpoints Sporadic test failure: shuffle_vec::test::test_shuffle_with_first

4 participants