core: fix AP login on Windows on ARM - #1761
Merged
kingosticks merged 1 commit intoSep 11, 2026
Merged
Conversation
This was referenced Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows on ARM currently advertises the legacy
PLATFORM_WINDOWS_CE_ARMidentifier in the AP handshake. Spotify rejects that platform during Premium login, as reported and isolated in #1758.This change maps Windows
armandaarch64targets to the supported desktopPLATFORM_WIN32_X86_64identifier. The platform selection is extracted into a small pure function so the Windows ARM behavior and existing x86 behavior are covered by unit tests.Validation:
cargo fmt --all -- --checkcargo test -p librespot-core windows_(2 passed)cargo build -p librespot-corecargo clippy -p librespot-core --all-targets -- -D warningsThe handshake mapping is covered here; final Spotify authentication on Windows ARM still needs confirmation from the reporter's hardware.
Closes #1758