discovery: fall back to IPv4 when IPv6 is unavailable - #1762
Open
iibaranov-IG wants to merge 1 commit into
Open
iibaranov-IG wants to merge 1 commit into
iibaranov-IG wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On IPv4-only Linux systems, the discovery HTTP server currently binds the IPv6 wildcard address and aborts startup when the kernel returns
Address family not supported. The libmdns responder already tolerates the same condition, but discovery never reaches it because the TCP listener fails first.This change keeps the preferred dual-stack IPv6 listener on supported non-Windows systems and retries with the IPv4 wildcard address when that bind fails. Windows continues to use IPv4 directly.
Validation:
cargo fmt --all -- --checkcargo test -p librespot-discovery discovery_listener(4 passed)net.ipv6.conf.all.disable_ipv6=1cargo build -p librespot-discoverycargo clippy -p librespot-discovery --all-targets -- -D warningsCloses #1736