clamp read and write length to INT_MAX in win32 posix shims - #1371
Open
sage-mode-hunter wants to merge 1 commit into
Open
clamp read and write length to INT_MAX in win32 posix shims#1371sage-mode-hunter wants to merge 1 commit into
sage-mode-hunter wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
posix_read/posix_write are the process-wide read()/write() on Windows (win32netcompat.h maps read/write to them) and pass their size_t count straight into the int-length socket and CRT calls:
Clamp count to INT_MAX in both shims before the call. POSIX allows read/write to move fewer bytes than requested so callers loop for the rest, and normal-sized I/O is unchanged.