Skip to content

Commit 1e2742e

Browse files
committed
modify:parameter and buffer check
1 parent c8c399b commit 1e2742e

2 files changed

Lines changed: 32 additions & 5 deletions

File tree

‎XEngine_Source/MQCore_DBModule/DBModule_MQData/DBModule_MQData.cpp‎

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -109,11 +109,8 @@ bool CDBModule_MQData::DBModule_MQData_Insert(XENGINE_DBMESSAGEQUEUE* pSt_DBInfo
109109
DBModule_dwErrorCode = ERROR_XENGINE_MQCORE_DATABASE_PARAMENT;
110110
return false;
111111
}
112-
XCHAR tszSQLStatement[10240];
113-
XCHAR tszSQLCoder[8192];
114-
115-
memset(tszSQLStatement, '\0', sizeof(tszSQLStatement));
116-
memset(tszSQLCoder, '\0', sizeof(tszSQLCoder));
112+
XCHAR tszSQLStatement[10240] = {};
113+
XCHAR tszSQLCoder[10240] = {};
117114

118115
DataBase_MySQL_Coder(xhDBSQL, pSt_DBInfo->tszMsgBuffer, tszSQLCoder, &pSt_DBInfo->nMsgLen);
119116
__int64u nRet = _xstprintf(tszSQLStatement, _X("INSERT INTO `%s` (tszUserName,tszUserBelong,tszQueueName,nQueueSerial,tszQueueLeftTime,tszQueuePublishTime,tszQueueData,nDataType,nDataAttr,tszQueueCreateTime) VALUES('%s','%s','%s',%lld,'%s','%s','"), pSt_DBInfo->tszQueueName, pSt_DBInfo->tszUserName, pSt_DBInfo->tszUserBelong, pSt_DBInfo->tszQueueName, pSt_DBInfo->nQueueSerial, pSt_DBInfo->tszQueueLeftTime, pSt_DBInfo->tszQueuePublishTime);

‎XEngine_Source/XEngine_MQServiceApp/MQService_Config.cpp‎

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -30,22 +30,47 @@ bool MQ_Service_Parament(int argc, char** argv, XENGINE_SERVERCONFIG* pSt_Startl
3030
}
3131
else if (0 == _tcsxcmp("-tp",argv[i]))
3232
{
33+
if (i + 1 >= argc)
34+
{
35+
MQ_Service_ParamentHelp();
36+
return false;
37+
}
3338
pSt_StartlParam->nTCPPort = _ttxoi(argv[++i]);
3439
}
3540
else if (0 == _tcsxcmp("-hp",argv[i]))
3641
{
42+
if (i + 1 >= argc)
43+
{
44+
MQ_Service_ParamentHelp();
45+
return false;
46+
}
3747
pSt_StartlParam->nHttpPort = _ttxoi(argv[++i]);
3848
}
3949
else if (0 == _tcsxcmp("-wp", argv[i]))
4050
{
51+
if (i + 1 >= argc)
52+
{
53+
MQ_Service_ParamentHelp();
54+
return false;
55+
}
4156
pSt_StartlParam->nWSPort = _ttxoi(argv[++i]);
4257
}
4358
else if (0 == _tcsxcmp("-mp", argv[i]))
4459
{
60+
if (i + 1 >= argc)
61+
{
62+
MQ_Service_ParamentHelp();
63+
return false;
64+
}
4565
pSt_StartlParam->nMQTTPort = _ttxoi(argv[++i]);
4666
}
4767
else if (0 == _tcsxcmp("-d",argv[i]))
4868
{
69+
if (i + 1 >= argc)
70+
{
71+
MQ_Service_ParamentHelp();
72+
return false;
73+
}
4974
pSt_StartlParam->bDeamon = _ttxoi(argv[++i]);
5075
}
5176
else if (0 == _tcsxcmp("-t", argv[i]))
@@ -58,6 +83,11 @@ bool MQ_Service_Parament(int argc, char** argv, XENGINE_SERVERCONFIG* pSt_Startl
5883
}
5984
else if (0 == _tcsxcmp("-l", argv[i]))
6085
{
86+
if (i + 1 >= argc)
87+
{
88+
MQ_Service_ParamentHelp();
89+
return false;
90+
}
6191
LPCXSTR lpszLogLevel = argv[++i];
6292
if (0 == _tcsxcmp("debug", lpszLogLevel))
6393
{

0 commit comments

Comments
 (0)