recognize 'takes' when dest square is empty (en passant) - #21399
Open
yafred wants to merge 3 commits into
Open
Conversation
jonbgamble
reviewed
Aug 24, 2026
Tested Co-authored-by: Jonathan Gamble <gamblej@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #21391
2026-08-24.17-39-14.mp4
Details (if needed)
line 432 supports en passant using the target square (for example: g6 in the video)
line 435 support 'takes' but only if the destination square is not empty (not the case with en passant) so we need to support a pawn going sideway to an empty square
When testing the fix, there is still disambiguation but only with one arrow ... this is likely due to my not so great accent