Remove redundant path clones

Avoid allocating paths before filesystem operations that only need
borrowed paths.

Co-Authored-By: HAL 9000

Author: tnull

src/io/fs_store.rs

@@ -26,8 +26,7 @@ pub(crate) async fn open_or_migrate_fs_store(
 	fs::create_dir_all(parent_dir).map_err(|_| BuildError::StoragePathAccessFailed)?;
 	recover_incomplete_fs_store_migration(&storage_dir_path)?;
 	if !storage_dir_path.exists() {
-		fs::create_dir_all(storage_dir_path.clone())
-			.map_err(|_| BuildError::StoragePathAccessFailed)?;
+		fs::create_dir_all(&storage_dir_path).map_err(|_| BuildError::StoragePathAccessFailed)?;
 	}
 
 	match FilesystemStoreV2::new(storage_dir_path.clone()) {
@@ -37,7 +36,7 @@ pub(crate) async fn open_or_migrate_fs_store(
 			let v1_store = FilesystemStore::new(storage_dir_path.clone());
 
 			let v2_dir = fs_store_sibling_path(&storage_dir_path, "fs_store_v2_migrating");
-			fs::create_dir_all(v2_dir.clone()).map_err(|_| BuildError::StoragePathAccessFailed)?;
+			fs::create_dir_all(&v2_dir).map_err(|_| BuildError::StoragePathAccessFailed)?;
 			let v2_store = FilesystemStoreV2::new(v2_dir.clone())
 				.map_err(|_| BuildError::KVStoreSetupFailed)?;