remove type casting & use try_into() for conversion

Author: Anyitechs

ldk-server/src/api/bolt11_send.rs

@@ -1,4 +1,5 @@
 use crate::api::error::LdkServerError;
+use crate::api::error::LdkServerErrorCode::InvalidRequestError;
 use crate::service::Context;
 use ldk_node::lightning::routing::router::RouteParametersConfig;
 use ldk_node::lightning_invoice::Bolt11Invoice;
@@ -13,12 +14,33 @@ pub(crate) fn handle_bolt11_send_request(
 	let invoice = Bolt11Invoice::from_str(&request.invoice.as_str())
 		.map_err(|_| ldk_node::NodeError::InvalidInvoice)?;
 
-	let route_parameters = request.route_parameters.map(|params| RouteParametersConfig {
-		max_total_routing_fee_msat: params.max_total_routing_fee_msat,
-		max_total_cltv_expiry_delta: params.max_total_cltv_expiry_delta,
-		max_path_count: params.max_path_count as u8,
-		max_channel_saturation_power_of_half: params.max_channel_saturation_power_of_half as u8,
-	});
+	let route_parameters = match request.route_parameters {
+		Some(params) => {
+			let max_path_count: u8 = params.max_path_count.try_into().map_err(|_| {
+				LdkServerError::new(
+					InvalidRequestError,
+					format!("Invalid max_path_count, must be between 0 and {}", u8::MAX),
+				)
+			})?;
+			let max_channel_saturation_power_of_half: u8 =
+				params.max_channel_saturation_power_of_half.try_into().map_err(|_| {
+					LdkServerError::new(
+						InvalidRequestError,
+						format!(
+							"Invalid max_channel_saturation_power_of_half, must be between 0 and {}",
+							u8::MAX
+						),
+					)
+				})?;
+			Some(RouteParametersConfig {
+				max_total_routing_fee_msat: params.max_total_routing_fee_msat,
+				max_total_cltv_expiry_delta: params.max_total_cltv_expiry_delta,
+				max_path_count,
+				max_channel_saturation_power_of_half,
+			})
+		},
+		None => None,
+	};
 
 	let payment_id = match request.amount_msat {
 		None => context.node.bolt11_payment().send(&invoice, route_parameters),

ldk-server/src/api/bolt12_send.rs

@@ -1,4 +1,5 @@
 use crate::api::error::LdkServerError;
+use crate::api::error::LdkServerErrorCode::InvalidRequestError;
 use crate::service::Context;
 use ldk_node::lightning::offers::offer::Offer;
 use ldk_node::lightning::routing::router::RouteParametersConfig;
@@ -13,12 +14,33 @@ pub(crate) fn handle_bolt12_send_request(
 	let offer =
 		Offer::from_str(&request.offer.as_str()).map_err(|_| ldk_node::NodeError::InvalidOffer)?;
 
-	let route_parameters = request.route_parameters.map(|params| RouteParametersConfig {
-		max_total_routing_fee_msat: params.max_total_routing_fee_msat,
-		max_total_cltv_expiry_delta: params.max_total_cltv_expiry_delta,
-		max_path_count: params.max_path_count as u8,
-		max_channel_saturation_power_of_half: params.max_channel_saturation_power_of_half as u8,
-	});
+	let route_parameters = match request.route_parameters {
+		Some(params) => {
+			let max_path_count = params.max_path_count.try_into().map_err(|_| {
+				LdkServerError::new(
+					InvalidRequestError,
+					format!("Invalid max_path_count, must be between 0 and {}", u8::MAX),
+				)
+			})?;
+			let max_channel_saturation_power_of_half =
+				params.max_channel_saturation_power_of_half.try_into().map_err(|_| {
+					LdkServerError::new(
+						InvalidRequestError,
+						format!(
+							"Invalid max_channel_saturation_power_of_half, must be between 0 and {}",
+							u8::MAX
+						),
+					)
+				})?;
+			Some(RouteParametersConfig {
+				max_total_routing_fee_msat: params.max_total_routing_fee_msat,
+				max_total_cltv_expiry_delta: params.max_total_cltv_expiry_delta,
+				max_path_count,
+				max_channel_saturation_power_of_half,
+			})
+		},
+		None => None,
+	};
 
 	let payment_id = match request.amount_msat {
 		None => context.node.bolt12_payment().send(