Skip to content

Expose funding_redeem_script and counterparty.features fields at gRPC boundary #272

Description

@elnafateh

Context

Follow-up to #251

  • ldk-node: 056447c28221be02c3d39f8c6ae430a67ebbd850
  • rust-lightning: 506cb91f2e0fb87906188b79777bcf42595d3623

1. funding_redeem_script: Option<ScriptBuf>

The witness script locking the funding output to commitment transactions. Useful for anyone
verifying/reconstructing the funding output — e.g. clients doing splice-in with externally
selected UTXOs need this to build the TxOut for the channel's existing funding outpoint
(see lightningdevkit/rust-lightning#4234 for the analogous need on the LDK side).

Proposed: add optional string funding_redeem_script = 33; (hex-encoded) to Channel.

2. counterparty.features: InitFeatures

The feature set our counterparty signaled on last connection (anchor outputs, splicing,
async payments, etc.) — useful for diagnosing why a feature-gated action (e.g. a splice)
fails against a given peer, and for routing-adjacent decisions.

Proposed: add map<uint32, Feature> counterparty_features = 34; to Channel, reusing the
existing Feature { name, is_required } message and features_to_proto() helper already
used for GraphNodeAnnouncement.features — call it with counterparty.features.le_flags()
and a Display-based closure, same pattern as the existing call sites.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions