Add default rest_service_address - #173
Merged
benthecarman merged 2 commits intoMar 25, 2026
Merged
Conversation
|
I've assigned @benthecarman as a reviewer! |
vincenzopalazzo
force-pushed
the
claude/recursing-dirac
branch
from
March 25, 2026 11:32
f4c8486 to
fb1f7f1
Compare
benthecarman
requested changes
Mar 25, 2026
Default `rest_service_address` to `127.0.0.1:3536` when omitted from the server config. Closes: lightningdevkit#160 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Use the same default REST address in the CLI when config omits `node.rest_service_address` and when `--base-url` is not provided.
vincenzopalazzo
force-pushed
the
claude/recursing-dirac
branch
from
March 25, 2026 18:06
8f44434 to
caf35e1
Compare
benthecarman
approved these changes
Mar 25, 2026
rsafier
pushed a commit
to rsafier/ldk-server
that referenced
this pull request
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rest_service_addressoptional in the config file with a default of127.0.0.1:3536defaultattribute so existing configs with the field set continue to work unchangedCloses #160
Test plan
test_read_json_config_from_filepasses (explicit address still works)test_default_rest_service_addresspasses (omitted field defaults to127.0.0.1:3536)cargo checkandcargo testpass🤖 Generated with Claude Code