Implement proper pagination for list-payments cli - #84
Merged
benthecarman merged 1 commit intoJan 7, 2026
Conversation
|
👋 I see @tankyleo was un-assigned. |
tankyleo
reviewed
Dec 11, 2025
Merged
benthecarman
force-pushed
the
pagination-payments
branch
from
December 16, 2025 23:25
2faead0 to
7614706
Compare
tankyleo
self-requested a review
December 16, 2025 23:28
benthecarman
force-pushed
the
pagination-payments
branch
from
December 17, 2025 12:45
7614706 to
bfc6312
Compare
benthecarman
force-pushed
the
pagination-payments
branch
from
December 18, 2025 05:32
bfc6312 to
f44c7fc
Compare
|
🔔 1st Reminder Hey @tankyleo! This PR has been waiting for your review. |
tankyleo
reviewed
Dec 19, 2025
tankyleo
approved these changes
Jan 7, 2026
benthecarman
added a commit
to benthecarman/ldk-server
that referenced
this pull request
Jan 9, 2026
Silent merge conflict from lightningdevkit#84, we were not enforcing clippy in CI when this was opened so it never ran.
benthecarman
added a commit
to benthecarman/ldk-server
that referenced
this pull request
Jan 9, 2026
Silent merge conflict from lightningdevkit#84, we were not enforcing clippy in CI when this was opened so it never ran.
rsafier
pushed a commit
to rsafier/ldk-server
that referenced
this pull request
Apr 20, 2026
rsafier
pushed a commit
to rsafier/ldk-server
that referenced
this pull request
Apr 20, 2026
Silent merge conflict from lightningdevkit#84, we were not enforcing clippy in CI when this was opened so it never ran.
tnull
pushed a commit
to tnull/ldk-server
that referenced
this pull request
Apr 27, 2026
Silent merge conflict from lightningdevkit#84, we were not enforcing clippy in CI when this was opened so it never ran.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another thing in the backend but not the cli