Skip to content

next_event_async might block Drop'ing the node #39

Description

@TheBlueMatt-macbook

If I have an application where I want to Drop the node (eg to reset the state and possibly create a new one), having a background loop running next_event_async is going to result in that not being possible. Its not really a huge deal because that just means the old node object will leak, but its kinda awkward. Either having a timeout on next_event_async (using tokio, I guess) so that exiting can happen, or letting it return Option<Event> and returning None immediately on stop() would suffice.

Similar to lightningdevkit/ldk-node#731

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions