Wire through missing deletion hints (#254)

Author: jogrogan

hoptimator-jdbc/src/main/java/com/linkedin/hoptimator/jdbc/TableService.java

@@ -106,7 +106,11 @@ public static void delete(Properties connectionProperties, List<String> path) th
 
     DatabaseConfigResolver resolver = DatabaseConfigResolvers.forProperties(connectionProperties);
     String database = resolver.databaseName(path);
-    Source source = new Source(database, path, Map.of());
+    // Merge connection hints into the Source options, mirroring create(): deployers read their
+    // configuration from source.options(), so an empty map here would strip hints that a deployer's
+    // teardown may depend on.
+    Map<String, String> tableOptions = new HashMap<>(DeploymentService.parseHints(connectionProperties));
+    Source source = new Source(database, path, tableOptions);
     DeploymentContext context = new DirectDeploymentContext(connectionProperties, resolver);
 
     Collection<Deployer> deployers = null;

hoptimator-jdbc/src/test/java/com/linkedin/hoptimator/jdbc/TableServiceTest.java

@@ -120,6 +120,27 @@ void deleteRunsValidationAndDeployerTeardown() throws SQLException {
     deployment.verify(() -> DeploymentService.restore(any()), never());
   }
 
+  @Test
+  void deleteMergesConnectionHintsIntoSourceOptions() throws SQLException {
+    // Connection hints must reach deployers via source.options() on delete just as they do on create;
+    // an empty options map would strip hints a deployer's teardown may depend on.
+    Deployer deployer = mock(Deployer.class);
+    List<Deployer> deployers = Collections.singletonList(deployer);
+    DatabaseConfigResolver resolver = stubResolver();
+    resolvers.when(() -> DatabaseConfigResolvers.forProperties(any())).thenReturn(resolver);
+    deployment.when(() -> DeploymentService.parseHints(any()))
+        .thenReturn(Map.of("hintKey", "hintValue"));
+    deployment.when(() -> DeploymentService.deployers(any(Source.class), any(DeploymentContext.class)))
+        .thenReturn(deployers);
+
+    TableService.delete(new Properties(), path);
+
+    ArgumentCaptor<Source> sourceCaptor = ArgumentCaptor.forClass(Source.class);
+    deployment.verify(() ->
+        DeploymentService.deployers(sourceCaptor.capture(), any(DeploymentContext.class)));
+    assertThat(sourceCaptor.getValue().options()).containsEntry("hintKey", "hintValue");
+  }
+
   @Test
   void deleteRestoresAndRethrowsWhenTeardownFails() {
     Deployer deployer = mock(Deployer.class);