system-monitor-graph@rcassani: network monitoring adjustments

[schorschii]

• I think it makes more sense to display network speed as bits/sec rather than bytes/sec, so I added an option for that and made it the default.
• The up/download speed sometimes overlaps, depending on the amount of chars of the current network speed. That's why, I moved this info into the smaller, right-aligned text3 label.
• Furthermore, I fixed some German translations.

What do you think @rcassani ?

[rcassani]

I think it makes more sense to display network speed as bits/sec rather than bytes/sec, so I added an option for that and made it the default.

That's a nice feature.
Just do not make the default. Similar as it is done within the GNOME System monitor, Bytes/s are default, but user can turn on the option to have bits/s. Also, it should play nicely with the prefixes (binary and decimal) to have kilobits and kibibits.

The up/download speed sometimes overlaps, depending on the amount of chars of the current network speed. That's why, I moved this info into the smaller, right-aligned text3 label.

Is this overlapping related to the change of units?
In the PR that introduced the network option, the size of the up/down text was discussed:
#1511 (review)

Furthermore, I fixed some German translations.
Really appreciated 🙏

EDIT: There is no need for bits with binary prefix.

[schorschii]

OK, I changed the order so that the new option is not default.

Is this overlapping related to the change of units?

No, I noticed the overlapping issue before my change. Sorry for mixing this up in one PR.

[rcassani]

It looks good!
One minor change is requested.

---

I'm curious about 7a31cf0, is there a list of fields for the metadata.json?

[rcassani]

For sake of coherency, it should be:
"Bits - Decimal prefix (1 Kb = 1000 bits)"

[rcassani]

After some tests, I agree the small text looks better.
FYI @FSSCoding

No, I noticed the overlapping issue before my change. Sorry for mixing this up in one PR.

There is no problem, several improvements can the in the same PR.

[schorschii]

One minor change is requested.

OK, done.

I'm curious about 7a31cf0, is there a list of fields for the metadata.json?

The "last-edited" field seems to be automatically added by Cinnamon when downloading the desklet. It is not allowed to be in the Git repo which is checked by this script. I accidentally added it to my first commit because after testing, I copied the entire ~/.local/share/cinnamon/desklets/system-monitor-graph@rcassani dir into my forked branch.

[rcassani]

@schorschii, thanks for the info about metadata.json

About the change in 9f5b323, it should be bits instead of bit

[rcassani]

@schorschii, thanks!
@rcalixte, this is ready to be merged!

[FSSCoding]

improvements

Thanks for the heads up I appreciate it. 😄
I’m not at all precious about any of the sizes or rate types. I’m just very happy that people are using it!
Great work 🙌