yfquotes@thegli - weekly and monthly change - #1857
Open
v-radev wants to merge 5 commits into
Open
Conversation
Author
|
@thegli please review whenever possible. Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds options to enable extra columns for weekly change and monthly change of each stock. The display value can be configured to be 1 of 3 options: percent change, absolute change (difference) or just display the market price from a week/month ago.
The data required for this is fetched with a single request if the tickers are up to 20, if they are more than 20, the requests are chunked to 20 tickers each, which is the limit forced by YF.
If one of the weekly or monthly options are enabled, the data is merged to the existing quotes data argument and then used when the labels are getting created. I think merging the data introduces the least amount of changes to existing methods and doesn't require any new arguments being passed around.