system-monitor-graph@rcassani: Add CPU fan monitoring - #1868
Conversation
|
I do not have the hardware to test this. Please provide some screenshots for of the desklet looks with this addition. In other thought, the fan status-speed is a variable, to me it makes more sense to have it's on graph, with the title: "CPU Fan speed xxx RPM [spaces] 🟢 On / 🔴 Off", then it would be possible to also see the history of the activity of the fan. |
|
@rcassani how does it look now |
rcassani
left a comment
There was a problem hiding this comment.
Hi @karthikmudaliarX, thank you so much for this feature, it is looking great. Please find here some of my comments, after addressing this is should be good to be merged.
rcassani
left a comment
There was a problem hiding this comment.
@karthikmudaliarX, for some reason this comment was not published in the previous review
|
Please resolve all conversations. |
|
@rcassani Is all that OK for you? |
rcassani
left a comment
There was a problem hiding this comment.
- The PR is ready once this small typo is addressed
- I do not have the hardware to test any of the options for CPU Fan detection. The code works well without Fan reported in
hwmon - If @karthikmudaliarX confirms the two options for CPU Fan detection are working properly the PR can be merged
Thank you both!
| "Usage" : "usage", | ||
| "Temperature" : "temperature" | ||
| "Temperature" : "temperature", | ||
| "Fan Speed" : "fan" |
There was a problem hiding this comment.
The change in the desklet settings was overseen:
Fan Speed --> Fan
There was a problem hiding this comment.
Fixed the settings label from Fan Speed to Fan.
For the hardware check, I’ve only been able to validate the Dell dell_smm fallback on my laptop. I tested it with the fan both running and stopped, and it works correctly. My machine doesn’t expose a CPU/processor-labelled fan sensor, so I haven’t been able to test that detection path on actual hardware.
Thanks for the review!
|
@claudiux this is ready to be merged, thanks |
What
0 RPMvalue0–4000graph range and reuse the standard single-series rendererWhy
A separate graph makes fan activity over time visible without mixing RPM into the CPU-temperature scale. Conservative sensor selection avoids mislabelling arbitrary chassis, GPU, PSU, or pump fans.
Screenshot
Captured on Linux Mint 22.3 / Cinnamon 6.6.7 using the
dell_smmhwmon driver.Verification
node --check system-monitor-graph@rcassani/files/system-monitor-graph@rcassani/desklet.js./validate-spice system-monitor-graph@rcassanimsgfmt --checkfor every translated cataloggit diff --checkKnown limitation
The repository has no automated Cinnamon desklet test harness for sysfs sensor variants. Zero, positive, missing, stale-path, and delayed-driver behavior were reviewed and hardware-smoke-tested but are not covered by unit tests. RPM values above 4000 remain numerically accurate but are clipped at the graph ceiling by design.
cc @rcassani