yfquotes@thegli: refactoring

[sulonetskyy]

• extract logging in a separate utility class
• use extracted logger instead of YahooFinanceQuoteUtils
• some minor fixes

[github-actions]

Best-practices scanner

This is a regex-based check for API usage that can pose security, performance or
maintainability issues, or that may already be provided by Cinnamon. Most findings
are advisory and do not automatically disqualify a pull request.

This check is not perfect and will not replace a normal review.

---

Found 1 potential issue(s):

⚠️ WARNING

⚠️ sync_file_query_exists

yfquotes@thegli/files/yfquotes@thegli/logger.js:19

this.debugging = DEBUGGING || Gio.file_new_for_path(DeskletManager.deskletMeta[this.uuid].path + "/DEBUG").query_exists(null);

query_exists() is a synchronous call that can block on slow/network filesystems.
Prefer attempting the operation and handling a Gio.IOErrorEnum.NOT_FOUND error instead.

---

Automated pattern check.

[sulonetskyy]

@thegli could you please review )

[github-actions]

Best-practices scanner

This is a regex-based check for API usage that can pose security, performance or
maintainability issues, or that may already be provided by Cinnamon. Most findings
are advisory and do not automatically disqualify a pull request.

This check is not perfect and will not replace a normal review.

---

Found 1 potential issue(s):

⚠️ WARNING

⚠️ sync_file_query_info

yfquotes@thegli/files/yfquotes@thegli/logger.js:28

file.query_info(Gio.FILE_ATTRIBUTE_STANDARD_TYPE, Gio.FileQueryInfoFlags.NONE, null);

Synchronous query_info() blocks the main loop.
Use query_info_async() instead.

---

Automated pattern check.

[github-actions]

Best-practices scanner

This is a regex-based check for API usage that can pose security, performance or
maintainability issues, or that may already be provided by Cinnamon. Most findings
are advisory and do not automatically disqualify a pull request.

This check is not perfect and will not replace a normal review.

---

Found 1 potential issue(s):

⚠️ WARNING

⚠️ sync_file_query_exists

yfquotes@thegli/files/yfquotes@thegli/logger.js:19

this.debugging = DEBUGGING || Gio.file_new_for_path(DeskletManager.deskletMeta[this.uuid].path + "/DEBUG").query_exists(null);

query_exists() is a synchronous call that can block on slow/network filesystems.
Prefer attempting the operation and handling a Gio.IOErrorEnum.NOT_FOUND error instead.

---

Automated pattern check.