Skip to content

fix(media): prevent getimagesize loopback deadlocks on missing images #1030

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
faisalahammad wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

fix(media): prevent getimagesize loopback deadlocks on missing images #1030

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0cf7fc2
fix(media): prevent getimagesize loopback deadlocks on missing images
faisalahammad Aug 7, 2026
b80438c
fix(media): reuse existing internal host check instead of new utility…
faisalahammad Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 23 additions & 2 deletions src/media.cls.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1146,7 +1146,7 @@ private function _detect_dimensions( $src ) {
$pathinfo = Utility::is_internal_file( $src );
if ( $pathinfo ) {
$src = $pathinfo[0];
} elseif ( apply_filters( 'litespeed_media_ignore_remote_missing_sizes', false ) ) {
} elseif ( $this->_is_internal_url( $src ) || apply_filters( 'litespeed_media_ignore_remote_missing_sizes', false ) ) {
return false;
}

Expand All @@ -1156,7 +1156,7 @@ private function _detect_dimensions( $src ) {

try {
$sizes = getimagesize( $src );
} catch ( \Exception $e ) {
} catch ( \Throwable $e ) {
return false;
}

Expand All @@ -1167,6 +1167,27 @@ private function _detect_dimensions( $src ) {
return false;
}

/**
* Check if a URL belongs to an internal site or CDN domain.
*
* @since 7.9
*
* @param string $url URL.
* @return bool True if internal host or relative path.
*/
private function _is_internal_url( $url ) {
if ( 'data:' === substr( $url, 0, 5 ) ) {
return false;
}

$url_parsed = wp_parse_url( $url );
if ( empty( $url_parsed['host'] ) ) {
return true;
}

return Utility::internal( $url_parsed['host'] ) || CDN::internal( $url_parsed['host'] );
}

/**
* Parse iframe src.
*
Expand Down
Loading