Skip to content

Commit d3a37bf

Browse files
samuelweisamuelwei
authored
Fix invalid return types (#247)
* Fix invalid return types * Fix tests
1 parent c6766ca commit d3a37bf

6 files changed

Lines changed: 206 additions & 208 deletions

File tree

‎src/Parameters/CreateMeetingParameters.php‎

Lines changed: 143 additions & 145 deletions
Original file line numberDiff line numberDiff line change
@@ -28,148 +28,148 @@
2828
use BigBlueButton\Util\SimpleXMLElementExtended;
2929

3030
/**
31-
* @method string getName()
32-
* @method $this setName(string $name)
33-
* @method string getMeetingID()
34-
* @method $this setMeetingID(string $id)
35-
* @method string getWelcome()
36-
* @method $this setWelcome(string $welcome)
37-
* @method string getDialNumber()
38-
* @method $this setDialNumber(string $dialNumber)
39-
* @method string getVoiceBridge()
40-
* @method $this setVoiceBridge(string $voiceBridge)
41-
* @method string getWebVoice()
42-
* @method $this setWebVoice(string $webVoice)
43-
* @method int getMaxParticipants()
44-
* @method $this setMaxParticipants(int $maxParticipants)
45-
* @method string getLoginURL()
46-
* @method $this setLoginURL(string $loginURL)
47-
* @method string getLogoutURL()
48-
* @method $this setLogoutURL(string $logoutURL)
49-
* @method bool|null isRecord()
50-
* @method $this setRecord(bool $isRecord)
51-
* @method bool|null isNotifyRecordingIsOn()
52-
* @method $this setNotifyRecordingIsOn(bool $isNotifyRecordingIsOn)
53-
* @method bool|null isRemindRecordingIsOn()
54-
* @method $this setRemindRecordingIsOn(bool $remindRecordingIsOn)
55-
* @method bool|null isRecordFullDurationMedia()
56-
* @method $this setRecordFullDurationMedia(bool $recordFullDurationMedia)
57-
* @method int getDuration()
58-
* @method $this setDuration(int $duration)
59-
* @method string getParentMeetingID()
60-
* @method $this setParentMeetingID(string $parentMeetingID)
61-
* @method int getSequence()
62-
* @method $this setSequence(int $sequence)
63-
* @method bool|null isFreeJoin()
64-
* @method $this setFreeJoin(bool $isFreeJoin)
65-
* @method bool|null isBreakoutRoomsPrivateChatEnabled()
66-
* @method $this setBreakoutRoomsPrivateChatEnabled(bool $isBreakoutRoomsPrivateChatEnabled)
67-
* @method bool|null isBreakoutRoomsRecord()
68-
* @method $this setBreakoutRoomsRecord(bool $isBreakoutRoomsRecord)
69-
* @method string getModeratorOnlyMessage()
70-
* @method $this setModeratorOnlyMessage(string $message)
71-
* @method bool|null isAutoStartRecording()
72-
* @method $this setAutoStartRecording(bool $isAutoStartRecording)
73-
* @method bool|null isAllowStartStopRecording()
74-
* @method $this setAllowStartStopRecording(bool $isAllow)
75-
* @method bool|null isWebcamsOnlyForModerator()
76-
* @method $this setWebcamsOnlyForModerator(bool $isWebcamsOnlyForModerator)
77-
* @method string getLogo()
78-
* @method $this setLogo(string $logo)
79-
* @method string getDarklogo()
80-
* @method $this setDarklogo(string $darklogo)
81-
* @method string getBannerText()
82-
* @method $this setBannerText(string $bannerText)
83-
* @method string getBannerColor()
84-
* @method $this setBannerColor(string $bannerColor)
85-
* @method string getCopyright()
86-
* @method $this setCopyright(string $copyright)
87-
* @method bool|null isMuteOnStart()
88-
* @method $this setMuteOnStart(bool $isMuteOnStart)
89-
* @method bool|null isAllowModsToUnmuteUsers()
90-
* @method $this setAllowModsToUnmuteUsers(bool $isAllowModsToUnmuteUsers)
91-
* @method bool|null isLockSettingsDisableCam()
92-
* @method $this setLockSettingsDisableCam(bool $isLockSettingsDisableCam)
93-
* @method bool|null isLockSettingsDisableMic()
94-
* @method $this setLockSettingsDisableMic(bool $isLockSettingsDisableMic)
95-
* @method bool|null isLockSettingsDisablePrivateChat()
96-
* @method $this setLockSettingsDisablePrivateChat(bool $isLockSettingsDisablePrivateChat)
97-
* @method bool|null isLockSettingsDisablePublicChat()
98-
* @method $this setLockSettingsDisablePublicChat(bool $isLockSettingsDisablePublicChat)
99-
* @method bool|null isLockSettingsDisableNotes()
100-
* @method $this setLockSettingsDisableNotes(bool $isLockSettingsDisableNotes)
101-
* @method bool|null isLockSettingsLockedLayout()
102-
* @method $this setLockSettingsLockedLayout(bool $isLockSettingsLockedLayout)
103-
* @method bool|null isLockSettingsHideUserList()
104-
* @method $this setLockSettingsHideUserList(bool $isLockSettingsHideUserList)
105-
* @method bool|null isLockSettingsLockOnJoin()
106-
* @method $this setLockSettingsLockOnJoin(bool $isLockSettingsLockOnJoin)
107-
* @method bool|null isLockSettingsLockOnJoinConfigurable()
108-
* @method $this setLockSettingsLockOnJoinConfigurable(bool $isLockSettingsLockOnJoinConfigurable)
109-
* @method $this setLockSettingsHideViewersCursor(bool $isLockSettingsHideViewersCursor)
110-
* @method bool|null isLockSettingsHideViewersCursor()
111-
* @method string getGuestPolicy()
112-
* @method $this setGuestPolicy(string $guestPolicy)
113-
* @method bool|null isMeetingKeepEvents()
114-
* @method $this setMeetingKeepEvents(bool $isMeetingKeepEvents)
115-
* @method bool|null isEndWhenNoModerator()
116-
* @method $this setEndWhenNoModerator(bool $isEndWhenNoModerator)
117-
* @method int getEndWhenNoModeratorDelayInMinutes()
118-
* @method $this setEndWhenNoModeratorDelayInMinutes(int $endWhenNoModeratorDelayInMinutes)
119-
* @method int getMeetingExpireIfNoUserJoinedInMinutes()
120-
* @method $this setMeetingExpireIfNoUserJoinedInMinutes(int $meetingExpireIfNoUserJoinedInMinutes)
121-
* @method int getMeetingExpireWhenLastUserLeftInMinutes()
122-
* @method $this setMeetingExpireWhenLastUserLeftInMinutes(int $meetingExpireWhenLastUserLeftInMinutes)
123-
* @method string getMeetingLayout()
124-
* @method $this setMeetingLayout(MeetingLayout $meetingLayout)
125-
* @method string getMeetingEndedURL()
126-
* @method $this setMeetingEndedURL(string $meetingEndedURL)
127-
* @method int getLearningDashboardCleanupDelayInMinutes()
128-
* @method $this setLearningDashboardCleanupDelayInMinutes(int $learningDashboardCleanupDelayInMinutes)
129-
* @method bool|null isAllowModsToEjectCameras()
130-
* @method $this setAllowModsToEjectCameras(bool $isAllowModsToEjectCameras)
131-
* @method bool|null isAllowRequestsWithoutSession()
132-
* @method $this setAllowRequestsWithoutSession(bool $isAllowRequestsWithoutSession)
133-
* @method bool|null isAllowPromoteGuestToModerator()
134-
* @method $this setAllowPromoteGuestToModerator(bool $isAllowPromoteGuestToModerator)
135-
* @method int getUserCameraCap()
136-
* @method $this setUserCameraCap(int $cap)
137-
* @method int getMeetingCameraCap()
138-
* @method $this setMeetingCameraCap(int $cap)
139-
* @method array getDisabledFeatures()
140-
* @method $this setDisabledFeatures(array $disabledFeatures)
141-
* @method array getDisabledFeaturesExclude()
142-
* @method $this setDisabledFeaturesExclude(array $disabledFeaturesExclude)
143-
* @method bool|null isPreUploadedPresentationOverrideDefault()
144-
* @method $this setPreUploadedPresentationOverrideDefault(bool $preUploadedPresentationOverrideDefault)
145-
* @method string getPresentationUploadExternalUrl()
146-
* @method $this setPresentationUploadExternalUrl(string $presentationUploadExternalUrl)
147-
* @method string getPresentationUploadExternalDescription()
148-
* @method $this setPresentationUploadExternalDescription(string $presentationUploadExternalDescription)
149-
* @method string getPreUploadedPresentation()
150-
* @method $this setPreUploadedPresentation(string $preUploadedPresentation)
151-
* @method string getPreUploadedPresentationName()
152-
* @method $this setPreUploadedPresentationName(string $preUploadedPresentationName)
153-
* @method int|null getMaxNumPages()
154-
* @method $this setMaxNumPages(int $maxNumPages)
155-
* @method string getPluginManifests()
156-
* @method $this setPluginManifests(string $pluginManifests)
157-
* @method string getPluginManifestsFetchUrl()
158-
* @method $this setPluginManifestsFetchUrl(string $pluginManifestsFetchUrl)
159-
* @method bool|null isPresentationConversionCacheEnabled()
160-
* @method $this setPresentationConversionCacheEnabled(bool $presentationConversionCacheEnabled)
161-
* @method bool|null isAllowOverrideClientSettingsOnCreateCall()
162-
* @method $this setAllowOverrideClientSettingsOnCreateCall(bool $allowOverrideClientSettingsOnCreateCall)
163-
* @method string getClientSettingsOverride()
164-
* @method $this setClientSettingsOverride(string $clientSettingsOverride)
165-
* @method string getClientSettingsOverrideJsonUrl()
166-
* @method $this setClientSettingsOverrideJsonUrl(string $clientSettingsOverrideJsonUrl)
167-
* @method bool|null isMultiUserWhiteboardEnabled()
168-
* @method $this setMultiUserWhiteboardEnabled(bool $multiUserWhiteboardEnabled)
169-
* @method string getSharedNotesEditor()
170-
* @method $this setSharedNotesEditor(string $sharedNotesEditor)
171-
* @method string getSharedNotesInitialContentJsonUrl()
172-
* @method $this setSharedNotesInitialContentJsonUrl(string $sharedNotesInitialContentJsonUrl)
31+
* @method string getName()
32+
* @method $this setName(string $name)
33+
* @method string getMeetingID()
34+
* @method $this setMeetingID(string $id)
35+
* @method string|null getWelcome()
36+
* @method $this setWelcome(string $welcome)
37+
* @method string|null getDialNumber()
38+
* @method $this setDialNumber(string $dialNumber)
39+
* @method string|null getVoiceBridge()
40+
* @method $this setVoiceBridge(string $voiceBridge)
41+
* @method string|null getWebVoice()
42+
* @method $this setWebVoice(string $webVoice)
43+
* @method int|null getMaxParticipants()
44+
* @method $this setMaxParticipants(int $maxParticipants)
45+
* @method string|null getLoginURL()
46+
* @method $this setLoginURL(string $loginURL)
47+
* @method string|null getLogoutURL()
48+
* @method $this setLogoutURL(string $logoutURL)
49+
* @method bool|null isRecord()
50+
* @method $this setRecord(bool $isRecord)
51+
* @method bool|null isNotifyRecordingIsOn()
52+
* @method $this setNotifyRecordingIsOn(bool $isNotifyRecordingIsOn)
53+
* @method bool|null isRemindRecordingIsOn()
54+
* @method $this setRemindRecordingIsOn(bool $remindRecordingIsOn)
55+
* @method bool|null isRecordFullDurationMedia()
56+
* @method $this setRecordFullDurationMedia(bool $recordFullDurationMedia)
57+
* @method int|null getDuration()
58+
* @method $this setDuration(int $duration)
59+
* @method string|null getParentMeetingID()
60+
* @method $this setParentMeetingID(string $parentMeetingID)
61+
* @method int|null getSequence()
62+
* @method $this setSequence(int $sequence)
63+
* @method bool|null isFreeJoin()
64+
* @method $this setFreeJoin(bool $isFreeJoin)
65+
* @method bool|null isBreakoutRoomsPrivateChatEnabled()
66+
* @method $this setBreakoutRoomsPrivateChatEnabled(bool $isBreakoutRoomsPrivateChatEnabled)
67+
* @method bool|null isBreakoutRoomsRecord()
68+
* @method $this setBreakoutRoomsRecord(bool $isBreakoutRoomsRecord)
69+
* @method string|null getModeratorOnlyMessage()
70+
* @method $this setModeratorOnlyMessage(string $message)
71+
* @method bool|null isAutoStartRecording()
72+
* @method $this setAutoStartRecording(bool $isAutoStartRecording)
73+
* @method bool|null isAllowStartStopRecording()
74+
* @method $this setAllowStartStopRecording(bool $isAllow)
75+
* @method bool|null isWebcamsOnlyForModerator()
76+
* @method $this setWebcamsOnlyForModerator(bool $isWebcamsOnlyForModerator)
77+
* @method string|null getLogo()
78+
* @method $this setLogo(string $logo)
79+
* @method string|null getDarklogo()
80+
* @method $this setDarklogo(string $darklogo)
81+
* @method string|null getBannerText()
82+
* @method $this setBannerText(string $bannerText)
83+
* @method string|null getBannerColor()
84+
* @method $this setBannerColor(string $bannerColor)
85+
* @method string|null getCopyright()
86+
* @method $this setCopyright(string $copyright)
87+
* @method bool|null isMuteOnStart()
88+
* @method $this setMuteOnStart(bool $isMuteOnStart)
89+
* @method bool|null isAllowModsToUnmuteUsers()
90+
* @method $this setAllowModsToUnmuteUsers(bool $isAllowModsToUnmuteUsers)
91+
* @method bool|null isLockSettingsDisableCam()
92+
* @method $this setLockSettingsDisableCam(bool $isLockSettingsDisableCam)
93+
* @method bool|null isLockSettingsDisableMic()
94+
* @method $this setLockSettingsDisableMic(bool $isLockSettingsDisableMic)
95+
* @method bool|null isLockSettingsDisablePrivateChat()
96+
* @method $this setLockSettingsDisablePrivateChat(bool $isLockSettingsDisablePrivateChat)
97+
* @method bool|null isLockSettingsDisablePublicChat()
98+
* @method $this setLockSettingsDisablePublicChat(bool $isLockSettingsDisablePublicChat)
99+
* @method bool|null isLockSettingsDisableNotes()
100+
* @method $this setLockSettingsDisableNotes(bool $isLockSettingsDisableNotes)
101+
* @method bool|null isLockSettingsLockedLayout()
102+
* @method $this setLockSettingsLockedLayout(bool $isLockSettingsLockedLayout)
103+
* @method bool|null isLockSettingsHideUserList()
104+
* @method $this setLockSettingsHideUserList(bool $isLockSettingsHideUserList)
105+
* @method bool|null isLockSettingsLockOnJoin()
106+
* @method $this setLockSettingsLockOnJoin(bool $isLockSettingsLockOnJoin)
107+
* @method bool|null isLockSettingsLockOnJoinConfigurable()
108+
* @method $this setLockSettingsLockOnJoinConfigurable(bool $isLockSettingsLockOnJoinConfigurable)
109+
* @method bool|null isLockSettingsHideViewersCursor()
110+
* @method $this setLockSettingsHideViewersCursor(bool $isLockSettingsHideViewersCursor)
111+
* @method GuestPolicy|null getGuestPolicy()
112+
* @method $this setGuestPolicy(string|GuestPolicy $guestPolicy)
113+
* @method bool|null isMeetingKeepEvents()
114+
* @method $this setMeetingKeepEvents(bool $isMeetingKeepEvents)
115+
* @method bool|null isEndWhenNoModerator()
116+
* @method $this setEndWhenNoModerator(bool $isEndWhenNoModerator)
117+
* @method int|null getEndWhenNoModeratorDelayInMinutes()
118+
* @method $this setEndWhenNoModeratorDelayInMinutes(int $endWhenNoModeratorDelayInMinutes)
119+
* @method int|null getMeetingExpireIfNoUserJoinedInMinutes()
120+
* @method $this setMeetingExpireIfNoUserJoinedInMinutes(int $meetingExpireIfNoUserJoinedInMinutes)
121+
* @method int|null getMeetingExpireWhenLastUserLeftInMinutes()
122+
* @method $this setMeetingExpireWhenLastUserLeftInMinutes(int $meetingExpireWhenLastUserLeftInMinutes)
123+
* @method MeetingLayout|null getMeetingLayout()
124+
* @method $this setMeetingLayout(string|MeetingLayout $meetingLayout)
125+
* @method string|null getMeetingEndedURL()
126+
* @method $this setMeetingEndedURL(string $meetingEndedURL)
127+
* @method int|null getLearningDashboardCleanupDelayInMinutes()
128+
* @method $this setLearningDashboardCleanupDelayInMinutes(int $learningDashboardCleanupDelayInMinutes)
129+
* @method bool|null isAllowModsToEjectCameras()
130+
* @method $this setAllowModsToEjectCameras(bool $isAllowModsToEjectCameras)
131+
* @method bool|null isAllowRequestsWithoutSession()
132+
* @method $this setAllowRequestsWithoutSession(bool $isAllowRequestsWithoutSession)
133+
* @method bool|null isAllowPromoteGuestToModerator()
134+
* @method $this setAllowPromoteGuestToModerator(bool $isAllowPromoteGuestToModerator)
135+
* @method int|null getUserCameraCap()
136+
* @method $this setUserCameraCap(int $cap)
137+
* @method int|null getMeetingCameraCap()
138+
* @method $this setMeetingCameraCap(int $cap)
139+
* @method array getDisabledFeatures()
140+
* @method $this setDisabledFeatures(array $disabledFeatures)
141+
* @method array getDisabledFeaturesExclude()
142+
* @method $this setDisabledFeaturesExclude(array $disabledFeaturesExclude)
143+
* @method bool|null isPreUploadedPresentationOverrideDefault()
144+
* @method $this setPreUploadedPresentationOverrideDefault(bool $preUploadedPresentationOverrideDefault)
145+
* @method string|null getPresentationUploadExternalUrl()
146+
* @method $this setPresentationUploadExternalUrl(string $presentationUploadExternalUrl)
147+
* @method string|null getPresentationUploadExternalDescription()
148+
* @method $this setPresentationUploadExternalDescription(string $presentationUploadExternalDescription)
149+
* @method string|null getPreUploadedPresentation()
150+
* @method $this setPreUploadedPresentation(string $preUploadedPresentation)
151+
* @method string|null getPreUploadedPresentationName()
152+
* @method $this setPreUploadedPresentationName(string $preUploadedPresentationName)
153+
* @method int|null getMaxNumPages()
154+
* @method $this setMaxNumPages(int $maxNumPages)
155+
* @method string|null getPluginManifests()
156+
* @method $this setPluginManifests(string $pluginManifests)
157+
* @method string|null getPluginManifestsFetchUrl()
158+
* @method $this setPluginManifestsFetchUrl(string $pluginManifestsFetchUrl)
159+
* @method bool|null isPresentationConversionCacheEnabled()
160+
* @method $this setPresentationConversionCacheEnabled(bool $presentationConversionCacheEnabled)
161+
* @method bool|null isAllowOverrideClientSettingsOnCreateCall()
162+
* @method $this setAllowOverrideClientSettingsOnCreateCall(bool $allowOverrideClientSettingsOnCreateCall)
163+
* @method string|null getClientSettingsOverride()
164+
* @method $this setClientSettingsOverride(string $clientSettingsOverride)
165+
* @method string|null getClientSettingsOverrideJsonUrl()
166+
* @method $this setClientSettingsOverrideJsonUrl(string $clientSettingsOverrideJsonUrl)
167+
* @method bool|null isMultiUserWhiteboardEnabled()
168+
* @method $this setMultiUserWhiteboardEnabled(bool $multiUserWhiteboardEnabled)
169+
* @method string|null getSharedNotesEditor()
170+
* @method $this setSharedNotesEditor(string $sharedNotesEditor)
171+
* @method string|null getSharedNotesInitialContentJsonUrl()
172+
* @method $this setSharedNotesInitialContentJsonUrl(string $sharedNotesInitialContentJsonUrl)
173173
*/
174174
final class CreateMeetingParameters extends MetaParameters
175175
{
@@ -209,7 +209,7 @@ final class CreateMeetingParameters extends MetaParameters
209209
protected ?bool $lockSettingsLockOnJoin = null;
210210
protected ?bool $lockSettingsLockOnJoinConfigurable = null;
211211
protected ?bool $lockSettingsHideViewersCursor = null;
212-
protected GuestPolicy $guestPolicy;
212+
protected ?GuestPolicy $guestPolicy = null;
213213
protected ?bool $meetingKeepEvents = null;
214214
protected ?bool $endWhenNoModerator = null;
215215
protected int $endWhenNoModeratorDelayInMinutes;
@@ -266,8 +266,6 @@ final class CreateMeetingParameters extends MetaParameters
266266

267267
public function __construct(protected string $meetingID, protected string $name)
268268
{
269-
$this->guestPolicy = GuestPolicy::ALWAYS_ACCEPT;
270-
271269
$this->ignoreProperties = ['disabledFeatures', 'disabledFeaturesExclude', 'clientSettingsOverride'];
272270
}
273271

‎src/Parameters/GetRecordingsParameters.php‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,12 @@
2525
/**
2626
* Class GetRecordingsParameters.
2727
*
28-
* @method string getMeetingID()
29-
* @method $this setMeetingID(string $id)
30-
* @method string getRecordID()
31-
* @method $this setRecordID(string $recordID)
32-
* @method string getState()
33-
* @method $this setState(string $state)
28+
* @method string|null getMeetingID()
29+
* @method $this setMeetingID(string $id)
30+
* @method string|null getRecordID()
31+
* @method $this setRecordID(string $recordID)
32+
* @method string|null getState()
33+
* @method $this setState(string $state)
3434
*/
3535
final class GetRecordingsParameters extends MetaParameters
3636
{

0 commit comments

Comments
 (0)