Repository navigation
i18n: add VB.NET (Wasm) keys to non-English locales - #1042
Merged
Merged
Conversation
✅ Deploy Preview for livecodes ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
7 tasks done
Contributor
|
Size Change: 0 B Total Size: 1.15 MB ℹ️ View Unchanged
|
Deploying livecodes with
|
| Latest commit: |
bc11ca5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ff2f06ad.livecodes.pages.dev |
| Branch Preview URL: | https://pullfrog-1041-add-vb-wasm-tr.livecodes.pages.dev |
Collaborator
|
The key values should be the translated text in each respective language not just a copy of English. Keep consistent in word choice with other entries in the same language. |
Contributor
Author
|
.error: "Tool execution aborted"
|
Collaborator
|
@pullfrog continue
|
Contributor
Author
|
Replaced the English placeholder values with real translations in all 17 non-English locales. Each locale's Verification:
|
|
hatemhosny
enabled auto-merge
September 17, 2026 23:22
Contributor
i18n ActionsSource PR has been merged into the default branch. Maintainers can comment |
Collaborator
|
.i18n-update-push |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #1041 added the
vb-wasmlanguage, but only populated theenlocale — all 17 non-English locales were left without the new keys. This adds them.For every non-English locale (
ar,bn,de,es,fa,fr,hi,hu,id,it,ja,nl,pt,ru,tr,ur,zh-CN):language-info.ts/language-info.lokalise.json:vbWasm.name,vbWasm.desc,vbWasm.linktranslation.ts/translation.lokalise.json:templates.starter.vb-wasmValues are real translations in each locale's own language, not English copies. Wording follows existing entries in each locale: the
desc/linkprose is adapted from that locale'scsharpWasmentry plus itsfsharpWasmwording for the.NET WebAssembly runtimephrase, and the starter label follows the locale'scsharp-wasm/zig-wasmpattern.name: 'VB.NET (Wasm)'stays Latin in every locale, matchingC# (Wasm).<tag-N>placeholder sequences are byte-identical toenin every locale.Verification
prettier --checkon the locale files: passedeslintonsrc/livecodes/i18n/locales: passednpm run test:i18n-exportandnpm run test:i18n-exclude: passed.lokalise.jsonfiles parse as valid JSONen(linktags 1–8,desctags 1–2) in every localeThe
typecheck:storybookfailure in the prepush hook is pre-existing (it needs a priornpm run build);typecheck:apppassed.DeepSeek Flash(free via Pullfrog for OSS) ｜ 𝕏