Skip to content

chore: remove unused oaiBuildFunctionInfo helper - #2333

Open
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-remove-unused-oaibuildfunctioninfo-helper-a6b1ec
Open

chore: remove unused oaiBuildFunctionInfo helper#2333
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/dead-code/chore-remove-unused-oaibuildfunctioninfo-helper-a6b1ec

Conversation

@detail-app

@detail-app detail-app Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Description

Removes the unused oaiBuildFunctionInfo helper from llm/utils.ts and its re-export from the llm barrel (llm/index.ts). The FunctionCall import in utils.ts is converted to a type-only import since the removed helper was its only runtime consumer.

Changes Made

  • Removed oaiBuildFunctionInfo from agents/src/llm/utils.ts
  • Removed the oaiBuildFunctionInfo re-export from agents/src/llm/index.ts
  • Updated the tracked API report (agents/etc/agents.api.md) to drop the removed symbol
  • Switched the FunctionCall import in utils.ts to type FunctionCall (cascading cleanup)

Context

oaiBuildFunctionInfo was marked @internal and had zero callers anywhere — no production code in agents/src, no plugin, no test, and no example referenced it (not even within its own source file). It was an internal helper accidentally leaked through the public barrel. The remaining zero-usage export candidates in the barrel (AsyncToolsetCreateOptions, FallbackAdapterOptions, FormatChatHistoryOptions, ChatContextValidationResult, ChatContextValidationSeverity, OpenAIFunctionParameters, DuplicatePromptArgs, ReplyPromptArgs) were kept because each has a production consumer within its own source file as a param/return/field type of a public API, so removing them would be an export-only removal, which is out of scope.

History

Pre-Review Checklist

  • Build passes: All builds (lint, typecheck, tests) pass locally
  • AI-generated code reviewed: Removed unnecessary comments and ensured code quality
  • Changes explained: All changes are properly documented and justified above
  • Scope appropriate: All changes relate to the PR title, or explanations provided for why they're included
  • Video demo: N/A (dead code removal)

Testing

  • Automated tests added/updated (if applicable)
  • All tests pass (401 passed, 2 pre-existing skips in src/llm/)
  • Make sure both restaurant_agent.ts and realtime_agent.ts work properly (for major changes)

Tooling: Detail: Dead Code

Additional Notes

pnpm api:check was already failing on main before this change due to unrelated pre-existing drift; this change keeps the report consistent with the new source for the removed symbol only.


Dead Code PRs can be configured here.

@detail-app
detail-app Bot requested a review from a team as a code owner August 24, 2026 20:22
@changeset-bot

changeset-bot Bot commented Aug 24, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 100eb26

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Open in Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants