chore: remove unused oaiBuildFunctionInfo helper - #2333
Open
detail-app[bot] wants to merge 1 commit into
Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the unused
oaiBuildFunctionInfohelper fromllm/utils.tsand its re-export from thellmbarrel (llm/index.ts). TheFunctionCallimport inutils.tsis converted to a type-only import since the removed helper was its only runtime consumer.Changes Made
oaiBuildFunctionInfofromagents/src/llm/utils.tsoaiBuildFunctionInfore-export fromagents/src/llm/index.tsagents/etc/agents.api.md) to drop the removed symbolFunctionCallimport inutils.tstotype FunctionCall(cascading cleanup)Context
oaiBuildFunctionInfowas marked@internaland had zero callers anywhere — no production code inagents/src, no plugin, no test, and no example referenced it (not even within its own source file). It was an internal helper accidentally leaked through the public barrel. The remaining zero-usage export candidates in the barrel (AsyncToolsetCreateOptions,FallbackAdapterOptions,FormatChatHistoryOptions,ChatContextValidationResult,ChatContextValidationSeverity,OpenAIFunctionParameters,DuplicatePromptArgs,ReplyPromptArgs) were kept because each has a production consumer within its own source file as a param/return/field type of a public API, so removing them would be an export-only removal, which is out of scope.History
Pre-Review Checklist
Testing
restaurant_agent.tsandrealtime_agent.tswork properly (for major changes)Tooling: Detail: Dead Code
Additional Notes
pnpm api:checkwas already failing onmainbefore this change due to unrelated pre-existing drift; this change keeps the report consistent with the new source for the removed symbol only.Dead Code PRs can be configured here.