fix: handle RoomIO microphone track replacement - #2363
Open
rosetta-livekit-bot[bot] wants to merge 1 commit into
Open
fix: handle RoomIO microphone track replacement#2363rosetta-livekit-bot[bot] wants to merge 1 commit into
rosetta-livekit-bot[bot] wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 9c4793c The changes in this PR will be included in the next version bump. This PR includes changesets to release 39 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🔍 Devin Review: 1 flag
Not posted on this PR by your GitHub settings — view it in Devin Review. (Configure)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ports livekit/agents#6744.
Verification
pnpm test agents(138 files, 2,287 passed, 5 skipped)pnpm --filter @livekit/agents buildpnpm --filter @livekit/agents typecheckcue-clivoice-mode session: final microphone transcription followed by the expected assistant framework eventpnpm --filter @livekit/agents lintwas run; it remains blocked by 25 unrelated existing formatting mismatches elsewhere in the package after the repository lock/config mismatch required a non-frozen dependency install. The changed files pass ESLint and the project formatter.Source diff coverage
livekit-agents/livekit/agents/voice/room_io/_input.py->agents/src/voice/room_io/_input.ts. Ported concrete track identity, authoritativeTrackUnsubscribedhandling, stale/duplicate event guards, close-state protection, listener cleanup, and replacement stream cleanup. The target usesMultiInputStreamcancellation/removal instead of Python asyncio forwarding tasks.tests/test_room_io.py->agents/src/voice/room_io/_input.test.ts. Ported applicable listener cleanup, same-publication replacement, duplicate subscribe, stale unsubscribe, active unsubscribe, superseded-stream cleanup, detached forwarding, and owned frame-processor lifecycle coverage.No required target infrastructure is missing for the ported behavior.
Ported from livekit/agents#6744
Original PR description
RoomIO treated the publication SID as track identity, so a replacement concrete track under the same publication was ignored. It also did not observe
track_unsubscribed.Track concrete identity and make the SDK unsubscribe and subscribe events authoritative. This avoids speculative stream recovery and follows the RTC lifecycle.
Addresses AGT-3239