Skip to content

fix: flush supported stt at manual and detected turn boundaries - #7285

Merged
chenghao-mou merged 11 commits into
mainfrom
chenghao/fix/AGT-3514-vad-eos-stt-flush
Oct 20, 2026
Merged

chenghao-mou merged 11 commits into
mainfrom
chenghao/fix/AGT-3514-vad-eos-stt-flush

Conversation

@chenghao-mou

@chenghao-mou chenghao-mou commented Sep 15, 2026 •

Copy link
Copy Markdown
Member

Add capability-gated STT flushing for manual commits and EOT. Only negative predictions delay flushing to half max_delay. Keep final-only EOT input, existing transcript triggers, and the audio-only stt_node contract.

ElevenLabs changes and tests are in #7287; other providers are deferred to #7989. Buffering custom nodes must disable manual_flush. Full-suite validation is blocked by server/credential fixtures.

Related: @IngLP's report #4087 and @longcw's capability proposal #4043.

Addresses AGT-3514 (Linear)

Initial prompt and agent context

Model: GPT-6

do we actually send _FlushSentinel to 11labs stt from VAD EOS?

okay, create a fix to flush STT with VAD EOS when STT supports it.

we can't change stt node contract, right? that means breaking change for any custom stt node implementation?

i guess it is okay, if they are buffering, they can disable by turn off manual flush.

so an ideal implementation is to flush in commit user turn (manual path) or to flush at EOT positive or some timeout when it is negative, does that sound right to you?

okay, let's do that, manual commit only uses flush if the STT supports that

we should keep it simple, just use the 1/2 value.

but we return 1.0 when there is an issue, right?

Keep final-only EOT input

can you move the 11labs changes to the other PR?

@chenghao-mou chenghao-mou added the review_effort:high Needs broad context and substantial validation label Sep 15, 2026
@chenghao-mou
chenghao-mou marked this pull request as ready for review September 15, 2026 13:22
@chenghao-mou
chenghao-mou requested a review from a team as a code owner September 15, 2026 13:23
devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

devin-ai-integration[bot]

This comment was marked as resolved.

@chenghao-mou
chenghao-mou marked this pull request as draft September 18, 2026 23:11
@chenghao-mou
chenghao-mou removed request for a team and longcw September 18, 2026 23:12
@chenghao-mou chenghao-mou changed the title fix: flush supported stt streams on vad end of speech fix: flush supported stt at manual and detected turn boundaries Sep 21, 2026
@chenghao-mou
chenghao-mou removed this pull request from stack #7288 September 21, 2026 13:53
@chenghao-mou
chenghao-mou added this pull request to stack #7979 October 20, 2026 10:01
@chenghao-mou
chenghao-mou merged commit ea304e5 into main Oct 20, 2026
24 checks passed
@chenghao-mou
chenghao-mou deleted the chenghao/fix/AGT-3514-vad-eos-stt-flush branch October 20, 2026 18:06
Sakuta014 added a commit to Sakuta014/agents that referenced this pull request Oct 21, 2026
The interim branch now reads it, so the STT-flush fixture from livekit#7285 needs
it like the other transcript fields AudioRecognition.__init__ sets.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

review_effort:high Needs broad context and substantial validation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants