Repository navigation
fix(hume, simli): make every __all__ entry resolve - #7981
Merged
Merged
Conversation
hume listed ModelVersion in __all__ without importing it, and simli listed Exception, which it never defines, so star imports of both packages raised AttributeError.
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
longcw
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
from livekit.plugins.hume import *andfrom livekit.plugins.simli import *both fail withAttributeError, because each package lists a name in__all__that it never binds. In hume that name isModelVersion: it is defined inhume/tts.pyand types themodel_versionargument ofTTS, but__init__.pynever imports it, sohume.ModelVersionraisesAttributeError: module 'livekit.plugins.hume' has no attribute 'ModelVersion'andfrom livekit.plugins.hume import ModelVersionraisesImportError. In simli the name isException, which the package doesn't define, and module attribute lookup does not fall back to builtins. Tools that read__all__, such as the pdoc docs build, are handed the same missing names.Changes
Import
ModelVersionin hume'sfrom .tts import (...)block, and remove"Exception"from simli's__all__.