Skip to content

Commit ebaad92

Browse files
MaxHeimbrockclaude
andcommitted
Rename Pools class to PoolFactory (resolves class/namespace name clash)
The static pool factory `Pools` lived inside the `LiveKit.Internal.FFI.Pools` namespace, so once FFIClient moved into LiveKit.Internal.FFI the namespace shadowed the class and forced a `FfiResponsePools` alias at the call site. Rename the class to `PoolFactory` (also a clearer name than `Pools.Pools`), rename the file to match, and drop the now-unneeded alias in FFIClient.cs. Internal-only type with a single call site; no API impact. Verified by compiling the LiveKit assembly via csc. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 1101040 commit ebaad92

3 files changed

Lines changed: 2 additions & 3 deletions

File tree

Runtime/Scripts/Internal/FFI/FFIClient.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
using LiveKit.Internal.FFI;
88
using LiveKit.Internal.FFI.Pools;
99
using LiveKit.Internal.FFI.Pools.Memory;
10-
using FfiResponsePools = LiveKit.Internal.FFI.Pools.Pools;
1110
using UnityEngine.Pool;
1211

1312
#if UNITY_EDITOR
@@ -65,7 +64,7 @@ internal sealed class FfiClient : IFFIClient
6564
// Data Track
6665
public event DataTrackStreamEventReceivedDelegate? DataTrackStreamEventReceived;
6766

68-
public FfiClient() : this(FfiResponsePools.NewFfiResponsePool(), new ArrayMemoryPool())
67+
public FfiClient() : this(PoolFactory.NewFfiResponsePool(), new ArrayMemoryPool())
6968
{
7069
}
7170

Runtime/Scripts/Internal/FFI/Pools/Pools.cs renamed to Runtime/Scripts/Internal/FFI/Pools/PoolFactory.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
namespace LiveKit.Internal.FFI.Pools
66
{
7-
public static class Pools
7+
public static class PoolFactory
88
{
99
public static IObjectPool<FfiResponse> NewFfiResponsePool()
1010
{
File renamed without changes.

0 commit comments

Comments
 (0)