Add StreamDestination ids to egress stream outputs (#1873)

* Add StreamDestination ids to egress stream outputs

Clients can tag each stream URL with their own id via
StreamOutput.destinations or UpdateStreamRequest.add_destinations, and
get it back on StreamInfo.id, since redacted URLs and the order of
stream_results can't identify a stream. RedactStreamKeys now redacts
destination URLs too.

* generated protobuf

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

Author: frostbyte73

.changeset/stream-destination-id.md

@@ -0,0 +1,5 @@
+---
+"@livekit/protocol": patch
+---
+
+`StreamDestination` (`id`, `url`) on `StreamOutput.destinations` and `UpdateStreamRequest.add_destinations`, echoed as `StreamInfo.id`, so a client can tell its streams apart; `RedactStreamKeys` redacts destination URLs

egress/redact.go

@@ -104,4 +104,9 @@ func RedactStreamKeys(stream *livekit.StreamOutput) {
 			stream.Urls[i] = redacted
 		}
 	}
+	for _, d := range stream.Destinations {
+		if redacted, ok := utils.RedactStreamKey(d.Url); ok {
+			d.Url = redacted
+		}
+	}
 }

egress/redact_test.go

@@ -112,6 +112,11 @@ func TestRedactStreamOutput(t *testing.T) {
 			"srt://foo.bar.com:9999",
 			"srt://foo.bar.com:9999?streamid=124939da-5244&passphrase=WnxknzJTUbwYl9SpdqAudX",
 		},
+		Destinations: []*livekit.StreamDestination{
+			{Id: "a", Url: "rtmps://foo.bar.com/app/secret_stream_key"},
+			{Id: "b", Url: "srt://foo.bar.com:9999?streamid=124939da-5244&passphrase=WnxknzJTUbwYl9SpdqAudX"},
+			{Id: "c", Url: "srt://foo.bar.com:9999"},
+		},
 	}
 
 	RedactStreamKeys(so)
@@ -120,6 +125,13 @@ func TestRedactStreamOutput(t *testing.T) {
 	require.Equal(t, "twitch://{liv...nop}", so.Urls[2])
 	require.Equal(t, "srt://foo.bar.com:9999", so.Urls[3])
 	require.Equal(t, "srt://foo.bar.com:9999?streamid={...}&passphrase={...}", so.Urls[4])
+
+	require.Equal(t, "rtmps://foo.bar.com/app/{sec...key}", so.Destinations[0].Url)
+	require.Equal(t, "srt://foo.bar.com:9999?streamid={...}&passphrase={...}", so.Destinations[1].Url)
+	require.Equal(t, "srt://foo.bar.com:9999", so.Destinations[2].Url)
+	require.Equal(t, "a", so.Destinations[0].Id)
+	require.Equal(t, "b", so.Destinations[1].Id)
+	require.Equal(t, "c", so.Destinations[2].Id)
 }
 
 func TestRedactEncodedOutputs(t *testing.T) {