Repository navigation
Add multi-track video, data and MCAP to MediaSource egress - #1882
Open
frostbyte73 wants to merge 3 commits into
Open
frostbyte73 wants to merge 3 commits into
frostbyte73 wants to merge 3 commits into
Conversation
MediaSource can now select several video tracks, data tracks, and tracks by name, with exclude selectors to drop matches, and EncodedFileType gains MCAP for writing each captured track as its own channel.
🦋 Changeset detectedLatest commit: 9a474d8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
biglittlebigben
left a comment
biglittlebigben
left a comment
Contributor
There was a problem hiding this comment.
LGTM but let's wait for the robotics team feedback
alan-george-lk
approved these changes
Oct 27, 2026
| string track_id = 1 [(logger.name) = "trackID"]; | ||
| string participant_identity = 2; | ||
| ParticipantInfo.Kind participant_kind = 3; | ||
| string track_name = 5; |
There was a problem hiding this comment.
How could we select "microphone" from "participant-a" but not "microphone" from "participant-b"?
Member
Author
There was a problem hiding this comment.
moved track_name out so it can be combined with identity or kind
Moving track_name out of the match oneof lets a selector combine a participant with a track name, so one participant's track can be captured or excluded without affecting same-named tracks from others.
milos-lk
approved these changes
Oct 27, 2026
stephen-derosa
approved these changes
Oct 27, 2026
| } | ||
|
|
||
| message VideoConfig { | ||
| bool capture_all = 1; |
There was a problem hiding this comment.
FMU: this capture all will capture all VideoTracks or all resolutions in the case of simulcast?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MediaSource can now select several video tracks, data tracks, and tracks by name, with exclude selectors to drop matches, and EncodedFileType gains MCAP for writing each captured track as its own channel.