Repository navigation
Conversation
🦋 Changeset detectedLatest commit: aa0a910 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
During a simulation, when an agent ends the call itself (for example with
EndCallTool), itson_simulation_endverdict is lost. The simulator sendsfinalize_simulationonly after it has judged the transcript, and by then the agent'sSessionHosthas already closed with itsAgentSession.livekit/agents#7986 fixes this by keeping the host up for the whole job. After that change, an agent that hangs up stays in the room until it is finalized. The simulator then needs a signal that the call ended other than the agent leaving.
What
This adds
AgentSessionEvent.SessionClosed { CloseReason reason = 1; optional string error = 2; }assession_closed = 24. The agent sends it when its session closes, and no session events follow it. It reuses theCloseReasonenum from #1887.Used by