Repository navigation
Add JobJoinTiming to UpdateJobStatus - #1900
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 619a57f The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
theomonnom
approved these changes
Oct 30, 2026
Comment on lines
+216
to
+217
| int64 prewarm_started_us = 6; // the agent's prewarm function, in the process that took the job | ||
| int64 prewarm_ended_us = 7; |
Member
There was a problem hiding this comment.
Suggested change
| int64 prewarm_started_us = 6; // the agent's prewarm function, in the process that took the job | |
| int64 prewarm_ended_us = 7; |
Member
There was a problem hiding this comment.
IMO we can remove those two, they're going to get removed in 2.0
Contributor
Author
There was a problem hiding this comment.
Will do @theomonnom . We can add it later if it fits in a different bucket.
This was referenced Oct 31, 2026
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Prewarm goes away in Agents 2.0. Fields renumbered before release. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
boks1971
marked this pull request as ready for review
November 4, 2026 08:08
boks1971
force-pushed
the
raja/agent-join-timing
branch
from
November 4, 2026 08:20
580fb99 to
619a57f
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An agent worker cannot tell the server the time of each step of an agent join. The server sees only two points: the job offer and the agent joining the room. This PR adds a place for the worker to report the steps between those two points.
Change
UpdateJobStatusgets a new field,join_timing, of the new messageJobJoinTiming. After the agent connects to the room, the worker sets it once.offer_received_usaccepted_usassignment_received_uslaunched_uslaunch_warmlaunched_usalso covers the agent's prewarm functionentrypoint_started_usconnect_called_usconnected_usThe values are instants on the worker host's monotonic clock, in microseconds. The server can subtract them from each other directly. To line them up with its own times, the server needs a clock offset, for example from the offer and accept round trip. The change only adds fields, so old servers and old workers keep working.
🤖 Generated with Claude Code