Repository navigation
TEL-1228: bump livekit-protocol/protocol to 85dd8b9 - #935
Closed
genseric-ghiro wants to merge 3 commits into
Closed
genseric-ghiro wants to merge 3 commits into
genseric-ghiro wants to merge 3 commits into
Conversation
genseric-ghiro
marked this pull request as ready for review
November 11, 2026 21:03
genseric-ghiro
requested review from
changt,
cloudwebrtc,
lukasIO and
xianshijing-lk
as code owners
November 11, 2026 21:03
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
genseric-ghiro
commented
Nov 11, 2026
|
|
||
| [tool.mypy] | ||
| exclude = "(build|setup\\.py|livekit-rtc/rust-sdks.*)" | ||
| exclude = "(build|setup\\.py|livekit-rtc/rust-sdks.*|livekit-protocol/protocol/.*)" |
Contributor
Author
There was a problem hiding this comment.
mypy type checking was running against this and failing in CI. If we want to enforce this check, we should do it in the protocol repo directly
1egoman
approved these changes
Nov 12, 2026
theomonnom
approved these changes
Nov 12, 2026
Contributor
Author
|
No longer needed, #936 has the fix and was already merged |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
livekit-protocol/protocolto get TEL-1228: add sip_source_call_id to CreateSIPParticipantRequest protocol#1960