libwebrtc: expose network_type on IceCandidateStats - #1363
Open
trypsynth wants to merge 3 commits into
Open
Conversation
|
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Contributor
|
@trypsynth cloud you please add the .changeset to this PR? |
Author
|
@cloudwebrtc Done |
Expose network_type on IceCandidateStats for libwebrtc, livekit, and livekit-ffi.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RTCIceCandidateStatscarries a non-standardnetworkTypefield (WiFi, cellular, ethernet, etc.), butIceCandidateStatshas no place to put it, so it's silently dropped duringget_stats()deserialization.pub network_type: Option<String>toIceCandidateStatsinlibwebrtc/src/stats.rs. The struct already derives#[serde(rename_all = "camelCase")] #[serde(default)], so this maps to the existingnetworkTypeJSON key and is non-breaking for any RTCIceCandidateStats that doesn't emit it (server-reflexive/relay/remote candidates, or non-Chromium backends).Test plan
cargo check -p libwebrtc