fix: guard room ConnectionState nil engine - #978
Open
mariusgassen wants to merge 1 commit into
Open
Conversation
…e is nil * with the refactoring of reading the connection state of a room directly from its non-exposed `engine`, that will panic if `nil` when the connection state is read * Current workaround: Check for an exposed `LocalParticipant`
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
mariusgassen
changed the title
cnderrauber
reviewed
Aug 26, 2026
| r.lock.RLock() | ||
| defer r.lock.RUnlock() | ||
|
|
||
| if r.engine == nil { |
Contributor
There was a problem hiding this comment.
r.engine is initiated in NewRoom and has never been cleared/reassign, it should not be nil. Could you share the panic stack?
Author
There was a problem hiding this comment.
We wrapped the room into a custom struct with business logic on it.
In a test we instantiate it with a &lksdk.Room{} instead of using NewRoom - this will cause the panic because the engine is never initialized.
I fixed our tests by using NewRoom(nil), however I thought a nil guard wouldn't hurt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
engine, that will panic ifnilwhen the connection state is readLocalParticipant