Feat/batch nodes - #442
Conversation
|
Can you also add an engine build command to You can ignore (or even remove) the multi-resolution builds as they are not used anymore (only slows down the script) comfystream/docker/entrypoint.sh Lines 96 to 101 in f13bd81 |
82528f7 to
5865571
Compare
|
@eliteprox which changes request is this i cant see it |
There was a problem hiding this comment.
Hi @lukiod I apologize for the delay getting back to you. I've tested the latest changes and still had issues with flickering frames. We recently had to fix some linting issues in the main branch, so please rebase and I will take a look.
Again, I apologize for the delay, this has been a lower priority feature since we have been working to ship BYOC pipelines and there were some overlapping changes in this PR.
Thank you again for this contribution, I've added the PR to our current planning cycle to maintain more visibility on this feature, as it is important to our roadmap. If it remains stale, we will pick up the feature in a coming sprint
78eea4a to
b27bf3e
Compare
|
rebased. found the likely cause of the flickering while doing it: short batches were padding with a duplicated last frame instead of blocking for a real one. loader now blocks per-frame with the timeout and raises instead of padding, so a batch is always N real frames. also dropped the queue-maxsize bump and a later pipeline-side commit that was fighting your state-manager refactor — kept the PR to LoadTensor's batch_size + SaveTensor's split_batch, no pipeline changes. heads up: i don't have a GPU streaming setup here so i couldn't actually re-test for flickering, just fixed the mechanism i think caused it. let me know if it's still there. |
No description provided.