refactor(echo): drop the quotes around the forward reference - #53
Merged
Conversation
PEP 563 is already active via `from __future__ import annotations`, so the annotation is stored as a string and never evaluated. Quoting the forward reference to EchoSession is redundant. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the echo example app’s type annotations by removing a redundant quoted forward reference now that from __future__ import annotations is enabled in the module.
Changes:
- Replace
state: "EchoSession | None"withstate: EchoSession | Noneinecho/runner.py.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
echo/runner.pyalready hasfrom __future__ import annotations, so PEP 563 stores every annotation as a string and never evaluates it. That makes the quotes around theEchoSessionforward reference redundant.The same cleanup applies to the trickle apps still on local branches (narrator, segmentation, sports-tracker); those will land with the PRs that introduce them, since none of the files exist on
mainyet.Verified: the module compiles, and
stateis the only quoted annotation onmain.