Skip to content

Commit 4bb0e44

Browse files
committed
Refactor - return PredbatData object
1 parent a40be9b commit 4bb0e44

3 files changed

Lines changed: 21 additions & 18 deletions

File tree

‎dist/Predbat-Table-Card-Next.js‎

Lines changed: 15 additions & 12 deletions
Large diffs are not rendered by default.

‎src/predbat-card.ts‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ import { modalStyles } from './styles/modal-styles';
1010
import { divElement, getVersionRowElement, haCardElement, styleElement, toggleCarCharging, toggleGeneratingPlan } from './utils/html-utils';
1111
import { PredbatService } from './services/predbat-service';
1212
import { PredbatData } from './PredbatData';
13-
import { RawData } from './schemas/predbat';
1413

1514
class PredbatTableCard extends HTMLElement {
1615
private _haService = new HomeAssistantService();
@@ -172,8 +171,8 @@ class PredbatTableCard extends HTMLElement {
172171
});
173172
}
174173

175-
public setPlanData = (validatedHistoricPlanData: RawData, validatedPlanData: RawData): void => {
176-
this._planData = new PredbatData(validatedHistoricPlanData, validatedPlanData);
174+
public setPlanData = (planData: PredbatData): void => {
175+
this._planData = planData;
177176

178177
this._render();
179178
};

‎src/services/predbat-service.ts‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,16 @@
1+
import { PredbatData } from '../PredbatData';
12
import { RawData, PredbatRawDataSchema } from '../schemas/predbat';
23

34
export class PredbatService {
4-
private _dataCallback: ((validatedHistoricPlanData: RawData, validatedPlanData: RawData) => void) | null;
5+
private _dataCallback: ((predbatData: PredbatData) => void) | null;
56
private _portRestApi: number;
67
private _updateIntervalRestApi: ReturnType<typeof setInterval> | null = null;
78
private _retryTimeoutRestApi: ReturnType<typeof setTimeout> | null = null;
89
private _isAvailableRestApi = false;
910
private _fetchInProgressRestApi = false;
1011
private _dataSource: 'REST_API' | 'HASS_STATES' | null = null;
1112

12-
public constructor(port: number, dataCallback: (validatedHistoricPlanData: RawData, validatedPlanData: RawData) => void) {
13+
public constructor(port: number, dataCallback: (predbatData: PredbatData) => void) {
1314
this._portRestApi = port;
1415
this._dataCallback = dataCallback;
1516

@@ -58,7 +59,7 @@ export class PredbatService {
5859

5960
if (this._dataCallback === null) throw new Error('this._dataCallback is null');
6061

61-
this._dataCallback(validatedHistoricPlanData, validatedPlanData);
62+
this._dataCallback(new PredbatData(validatedHistoricPlanData, validatedPlanData));
6263
}
6364
catch (error) {
6465
console.error(error);

0 commit comments

Comments
 (0)