Repository navigation
Preserve focused virtual rows and mobile layout geometry - #258
Closed
tiensonqin wants to merge 7 commits into
Closed
tiensonqin wants to merge 7 commits into
tiensonqin wants to merge 7 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scrolling a focused virtual row offscreen could detach its native editor and dismiss the keyboard. Keep one pinned row in a persistent overlay while reserving its measured lazy-list position. Preserve drawer swipes over fitting horizontal content, and stretch Android row children to their measured content height so table dividers remain visible.
Inline search fields resolve their fill from the application's semantic surface token. Native menu triggers honor explicit start/center/end text alignment inside their minimum touch region while preserving adaptive width and centered defaults. Shared/generated schemas and Android restrictive-property value validation agree.
Android retained-tree validation now admits regular Button/ToggleButton label content alongside context-menu metadata, matching the shared protocol and the renderer. Actual leaf controls continue to reject container children.
Validation: 20 OCaml protocol cases, 9 schema-generator checks and all 12 standalone Android store cases pass, including invalid alignment rejection and custom-label/leaf-control boundaries. Consumer iOS native checks cover retained focus/images, editor position, drawer gestures, leading All labels, actual embed glyphs, block-sized query triangles, command-form inputs, search/link caret taps and query/table/gallery/filter/sort/search/error behavior. Search screenshots cover light/dark, focused/unfocused and app appearance overrides. The rebuilt Android consumer passes all eight query/view instrumentation cases, plus five completion/form/paste/recovery cases. The earlier Paparazzi row-stretch regression passes and its screenshot was inspected. No XCTest runner was used.
Consumer integration regressions and installation evidence are recorded in mobile #69. The exact separately reported iOS 27.0.1 TestFlight AttributeGraph crash remains unproven; this PR does not claim to fix it.
Continuation: LUI #259 carries these unmerged consumer-pinned fixes and repairs custom Apple Button/ToggleButton labels.